From: "Emilio G. Cota" <cota@braap.org>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>,
Fam Zheng <famz@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 2/4] qemu-thread: introduce qemu-thread-common.h
Date: Tue, 24 Apr 2018 11:46:52 -0400 [thread overview]
Message-ID: <20180424154652.GA22209@flamenco> (raw)
In-Reply-To: <20180424045112.12963-3-peterx@redhat.com>
On Tue, Apr 24, 2018 at 12:51:10 +0800, Peter Xu wrote:
> Introduce some hooks for the shared part of qemu thread between POSIX
> and Windows implementations. Note that in qemu_mutex_unlock_impl() we
> moved the call before unlock operation which should make more sense.
> And we don't need qemu_mutex_post_unlock() hook.
>
> Currently the hooks only calls the tracepoints.
This line is obsolete -- in _init we set ->initialized.
> Put all these shared hooks into the header files. It should be internal
> to qemu-thread but not for qemu-thread users, hence put into util/
> directory.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
(snip)
> +++ b/util/qemu-thread-common.h
(snip)
> +#ifndef __QEMU_THREAD_COMMON_H__
> +#define __QEMU_THREAD_COMMON_H__
Please change to QEMU_THREAD_COMMON_H, without the double underscore.
(_* and __* identifiers are reserved for the C library)
Otherwise:
Reviewed-by: Emilio G. Cota <cota@braap.org>
Thanks,
Emilio
next prev parent reply other threads:[~2018-04-24 15:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 4:51 [Qemu-devel] [PATCH v5 0/4] qemu-thread: support --enable-debug-mutex Peter Xu
2018-04-24 4:51 ` [Qemu-devel] [PATCH v5 1/4] tests/atomic_add-bench: add -m option to use mutexes Peter Xu
2018-04-24 4:51 ` [Qemu-devel] [PATCH v5 2/4] qemu-thread: introduce qemu-thread-common.h Peter Xu
2018-04-24 15:46 ` Emilio G. Cota [this message]
2018-04-24 4:51 ` [Qemu-devel] [PATCH v5 3/4] QemuMutex: support --enable-debug-mutex Peter Xu
2018-04-24 15:47 ` Emilio G. Cota
2018-04-24 4:51 ` [Qemu-devel] [PATCH v5 4/4] configure: enable debug-mutex if debug enabled Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424154652.GA22209@flamenco \
--to=cota@braap.org \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).