From: Kevin Wolf <kwolf@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Jeff Cody <jcody@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>,
Liang Li <liliang.opensource@gmail.com>,
qemu-stable@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] block/mirror: honor ratelimit again
Date: Tue, 24 Apr 2018 19:13:27 +0200 [thread overview]
Message-ID: <20180424171327.GG4080@localhost.localdomain> (raw)
In-Reply-To: <20180424123527.19168-1-stefanha@redhat.com>
Am 24.04.2018 um 14:35 hat Stefan Hajnoczi geschrieben:
> Commit b76e4458b1eb3c32e9824fe6aa51f67d2b251748 ("block/mirror: change
> the semantic of 'force' of block-job-cancel") accidentally removed the
> ratelimit in the mirror job.
>
> Reintroduce the ratelimit but keep the block-job-cancel force=true
> behavior that was added in commit
> b76e4458b1eb3c32e9824fe6aa51f67d2b251748.
>
> Note that block_job_sleep_ns() returns immediately when the job is
> cancelled. Therefore it's safe to unconditionally call
> block_job_sleep_ns() - a cancelled job does not sleep.
>
> This commit fixes the non-deterministic qemu-iotests 185 output. The
> test relies on the ratelimit to make the job sleep until the 'quit'
> command is processed. Previously the job could complete before the
> 'quit' command was received since there was no ratelimit.
>
> Cc: Liang Li <liliang.opensource@gmail.com>
> Cc: Jeff Cody <jcody@redhat.com>
> Cc: Kevin Wolf <kwolf@redhat.com>
> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-stable@nongnu.org
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
next prev parent reply other threads:[~2018-04-24 17:13 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 12:35 [Qemu-devel] [PATCH] block/mirror: honor ratelimit again Stefan Hajnoczi
2018-04-24 17:13 ` Kevin Wolf [this message]
2018-04-24 17:30 ` Jeff Cody
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180424171327.GG4080@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=jcody@redhat.com \
--cc=liliang.opensource@gmail.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).