From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, alex.bennee@linaro.org
Subject: [Qemu-devel] [PATCH 4/9] target/arm: Clear SVE high bits for FMOV
Date: Tue, 24 Apr 2018 15:22:55 -1000 [thread overview]
Message-ID: <20180425012300.14698-5-richard.henderson@linaro.org> (raw)
In-Reply-To: <20180425012300.14698-1-richard.henderson@linaro.org>
Use write_fp_dreg and clear_vec_high to zero the bits
that need zeroing for these cases.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/arm/translate-a64.c | 17 +++++------------
1 file changed, 5 insertions(+), 12 deletions(-)
diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index b27892d971..f2241d8174 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -5356,31 +5356,24 @@ static void handle_fmov(DisasContext *s, int rd, int rn, int type, bool itof)
if (itof) {
TCGv_i64 tcg_rn = cpu_reg(s, rn);
+ TCGv_i64 tmp;
switch (type) {
case 0:
- {
/* 32 bit */
- TCGv_i64 tmp = tcg_temp_new_i64();
+ tmp = tcg_temp_new_i64();
tcg_gen_ext32u_i64(tmp, tcg_rn);
- tcg_gen_st_i64(tmp, cpu_env, fp_reg_offset(s, rd, MO_64));
- tcg_gen_movi_i64(tmp, 0);
- tcg_gen_st_i64(tmp, cpu_env, fp_reg_hi_offset(s, rd));
+ write_fp_dreg(s, rd, tmp);
tcg_temp_free_i64(tmp);
break;
- }
case 1:
- {
/* 64 bit */
- TCGv_i64 tmp = tcg_const_i64(0);
- tcg_gen_st_i64(tcg_rn, cpu_env, fp_reg_offset(s, rd, MO_64));
- tcg_gen_st_i64(tmp, cpu_env, fp_reg_hi_offset(s, rd));
- tcg_temp_free_i64(tmp);
+ write_fp_dreg(s, rd, tcg_rn);
break;
- }
case 2:
/* 64 bit to top half. */
tcg_gen_st_i64(tcg_rn, cpu_env, fp_reg_hi_offset(s, rd));
+ clear_vec_high(s, true, rd);
break;
}
} else {
--
2.14.3
next prev parent reply other threads:[~2018-04-25 1:23 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 1:22 [Qemu-devel] [PATCH 0/9] target/arm: Fixups for ARM_FEATURE_V8_FP16 Richard Henderson
2018-04-25 1:22 ` [Qemu-devel] [PATCH 1/9] target/arm: Implement vector shifted SCVF/UCVF for fp16 Richard Henderson
2018-04-27 16:04 ` Alex Bennée
2018-04-29 14:44 ` Richard Henderson
2018-04-29 15:27 ` Peter Maydell
2018-04-25 1:22 ` [Qemu-devel] [PATCH 2/9] target/arm: Implement vector shifted FCVT " Richard Henderson
2018-04-30 15:55 ` Alex Bennée
2018-04-25 1:22 ` [Qemu-devel] [PATCH 3/9] target/arm: Fix float16 to/from int16 Richard Henderson
2018-05-01 10:10 ` Alex Bennée
2018-04-25 1:22 ` Richard Henderson [this message]
2018-05-01 10:44 ` [Qemu-devel] [PATCH 4/9] target/arm: Clear SVE high bits for FMOV Alex Bennée
2018-04-25 1:22 ` [Qemu-devel] [PATCH 5/9] target/arm: Implement FMOV (general) for fp16 Richard Henderson
2018-04-25 1:31 ` Philippe Mathieu-Daudé
2018-04-25 8:40 ` Richard Henderson
2018-04-25 1:22 ` [Qemu-devel] [PATCH 6/9] target/arm: Implement FCVT (scalar, integer) " Richard Henderson
2018-05-01 10:55 ` Alex Bennée
2018-04-25 1:22 ` [Qemu-devel] [PATCH 7/9] target/arm: Implement FCVT (scalar, fixed-point) " Richard Henderson
2018-05-01 10:57 ` Alex Bennée
2018-04-25 1:22 ` [Qemu-devel] [PATCH 8/9] target/arm: Implement FP data-processing (2 source) " Richard Henderson
2018-05-01 11:13 ` Alex Bennée
2018-05-02 18:28 ` Richard Henderson
2018-05-02 18:47 ` Richard Henderson
2018-04-25 1:23 ` [Qemu-devel] [PATCH 9/9] target/arm: Implement FP data-processing (3 " Richard Henderson
2018-05-01 11:21 ` Alex Bennée
2018-05-02 18:49 ` Richard Henderson
2018-04-25 1:35 ` [Qemu-devel] [PATCH 0/9] target/arm: Fixups for ARM_FEATURE_V8_FP16 no-reply
2018-04-25 9:14 ` Alex Bennée
2018-04-27 17:22 ` Alex Bennée
2018-04-27 18:55 ` Alex Bennée
2018-04-27 19:50 ` Alex Bennée
2018-05-11 2:17 ` Richard Henderson
2018-05-11 21:13 ` Alex Bennée
2018-05-01 15:47 ` Alex Bennée
2018-05-01 18:35 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425012300.14698-5-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=alex.bennee@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).