From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, war2jordan@live.com,
crosthwaite.peter@gmail.com, boost.lists@gmail.com,
quintela@redhat.com, ciro.santilli@gmail.com,
jasowang@redhat.com, mst@redhat.com, zuban32s@gmail.com,
armbru@redhat.com, maria.klimushenkova@ispras.ru,
dovgaluk@ispras.ru, kraxel@redhat.com, pavel.dovgaluk@ispras.ru,
thomas.dullien@googlemail.com, pbonzini@redhat.com,
mreitz@redhat.com, alex.bennee@linaro.org, dgilbert@redhat.com,
rth@twiddle.net
Subject: [Qemu-devel] [RFC PATCH 11/17] replay: flush events when exitting
Date: Wed, 25 Apr 2018 15:46:38 +0300 [thread overview]
Message-ID: <20180425124637.17182.7927.stgit@pasha-VirtualBox> (raw)
In-Reply-To: <20180425124533.17182.53165.stgit@pasha-VirtualBox>
This patch adds events processing when emulation finishes instead
of just cleaning the queue. Now the bdrv coroutines will be in consistent
state when emulator closes. It allows correct polling of the block layer
at exit.
Signed-off-by: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
---
replay/replay-events.c | 14 +-------------
replay/replay-internal.h | 2 --
2 files changed, 1 insertion(+), 15 deletions(-)
diff --git a/replay/replay-events.c b/replay/replay-events.c
index 707de38..0964a82 100644
--- a/replay/replay-events.c
+++ b/replay/replay-events.c
@@ -94,18 +94,6 @@ void replay_disable_events(void)
}
}
-void replay_clear_events(void)
-{
- g_assert(replay_mutex_locked());
-
- while (!QTAILQ_EMPTY(&events_list)) {
- Event *event = QTAILQ_FIRST(&events_list);
- QTAILQ_REMOVE(&events_list, event, events);
-
- g_free(event);
- }
-}
-
/*! Adds specified async event to the queue */
void replay_add_event(ReplayAsyncEventKind event_kind,
void *opaque,
@@ -308,7 +296,7 @@ void replay_init_events(void)
void replay_finish_events(void)
{
events_enabled = false;
- replay_clear_events();
+ replay_flush_events();
}
bool replay_events_enabled(void)
diff --git a/replay/replay-internal.h b/replay/replay-internal.h
index 34d19eb..a2221e5 100644
--- a/replay/replay-internal.h
+++ b/replay/replay-internal.h
@@ -148,8 +148,6 @@ void replay_init_events(void);
void replay_finish_events(void);
/*! Flushes events queue */
void replay_flush_events(void);
-/*! Clears events list before loading new VM state */
-void replay_clear_events(void);
/*! Returns true if there are any unsaved events in the queue */
bool replay_has_events(void);
/*! Saves events from queue into the file */
next prev parent reply other threads:[~2018-04-25 12:46 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 12:45 [Qemu-devel] [RFC PATCH 00/17] reverse debugging Pavel Dovgalyuk
2018-04-25 12:45 ` [Qemu-devel] [RFC PATCH 01/17] block: implement bdrv_snapshot_goto for blkreplay Pavel Dovgalyuk
2018-04-25 12:45 ` [Qemu-devel] [RFC PATCH 02/17] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2018-04-25 12:45 ` [Qemu-devel] [RFC PATCH 03/17] replay: update docs for record/replay with block devices Pavel Dovgalyuk
2018-04-25 12:45 ` [Qemu-devel] [RFC PATCH 04/17] replay: don't drain/flush bdrv queue while RR is working Pavel Dovgalyuk
2018-04-25 12:46 ` [Qemu-devel] [RFC PATCH 05/17] replay: finish record/replay before closing the disks Pavel Dovgalyuk
2018-04-25 12:46 ` [Qemu-devel] [RFC PATCH 06/17] migration: introduce icount field for snapshots Pavel Dovgalyuk
2018-04-25 18:59 ` Eric Blake
2018-04-26 9:40 ` Pavel Dovgalyuk
2018-04-25 12:46 ` [Qemu-devel] [RFC PATCH 07/17] qcow2: " Pavel Dovgalyuk
2018-04-25 19:01 ` Eric Blake
2018-04-25 12:46 ` [Qemu-devel] [RFC PATCH 08/17] replay: introduce info hmp/qmp command Pavel Dovgalyuk
2018-04-25 19:06 ` Eric Blake
2018-04-25 12:46 ` [Qemu-devel] [RFC PATCH 09/17] replay: introduce breakpoint at the specified step Pavel Dovgalyuk
2018-04-25 19:07 ` Eric Blake
2018-04-25 12:46 ` [Qemu-devel] [RFC PATCH 10/17] replay: implement replay_seek command to proceed to the desired step Pavel Dovgalyuk
2018-04-25 19:07 ` Eric Blake
2018-04-25 12:46 ` Pavel Dovgalyuk [this message]
2018-04-25 12:46 ` [Qemu-devel] [RFC PATCH 12/17] timer: remove replay clock probe in deadline calculation Pavel Dovgalyuk
2018-04-25 12:46 ` [Qemu-devel] [RFC PATCH 13/17] replay: refine replay-time module Pavel Dovgalyuk
2018-04-25 12:46 ` [Qemu-devel] [RFC PATCH 14/17] translator: fix breakpoint processing Pavel Dovgalyuk
2018-04-25 12:47 ` [Qemu-devel] [RFC PATCH 15/17] replay: flush rr queue before loading the vmstate Pavel Dovgalyuk
2018-04-25 12:47 ` [Qemu-devel] [RFC PATCH 16/17] gdbstub: add reverse step support in replay mode Pavel Dovgalyuk
2018-04-25 12:47 ` [Qemu-devel] [RFC PATCH 17/17] gdbstub: add reverse continue " Pavel Dovgalyuk
2018-04-25 12:48 ` [Qemu-devel] [RFC PATCH 00/17] reverse debugging Pavel Dovgalyuk
2018-04-26 12:21 ` Ciro Santilli
2018-04-26 12:34 ` Pavel Dovgalyuk
[not found] ` <CAFXrp_ddY34M8J+BwaRhPJrzxk=0XaQSBss1WnnZ8fNzAX+BjQ@mail.gmail.com>
[not found] ` <000401d3dec8$9c02c8d0$d4085a70$@ru>
2018-04-28 8:17 ` Ciro Santilli
2018-08-10 15:41 ` Ciro Santilli
[not found] ` <CAFXrp_dOLnuoBEhL0eUJtobRWq7gjgAR8X48Xb3JeNx1J4eHEw@mail.gmail.com>
2018-04-28 8:14 ` [Qemu-devel] Fwd: " Ciro Santilli
[not found] ` <000e01d3ded3$127660d0$37632270$@ru>
2018-04-28 9:38 ` [Qemu-devel] " Ciro Santilli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425124637.17182.7927.stgit@pasha-VirtualBox \
--to=pavel.dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=boost.lists@gmail.com \
--cc=ciro.santilli@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=dovgaluk@ispras.ru \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=thomas.dullien@googlemail.com \
--cc=war2jordan@live.com \
--cc=zuban32s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).