From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:60344) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBJwl-0000Qc-EL for qemu-devel@nongnu.org; Wed, 25 Apr 2018 08:54:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fBJwi-0005uu-7u for qemu-devel@nongnu.org; Wed, 25 Apr 2018 08:54:55 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:38620 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fBJwi-0005uo-3G for qemu-devel@nongnu.org; Wed, 25 Apr 2018 08:54:52 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 942DCEBFF7 for ; Wed, 25 Apr 2018 12:54:51 +0000 (UTC) Date: Wed, 25 Apr 2018 13:54:46 +0100 From: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= Message-ID: <20180425125446.GJ30024@redhat.com> Reply-To: Daniel =?utf-8?B?UC4gQmVycmFuZ8Op?= References: <20180424214550.32549-1-lersek@redhat.com> <20180424214550.32549-4-lersek@redhat.com> <5f76e0aa-389f-82b8-9bac-8405f51b8d2c@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <5f76e0aa-389f-82b8-9bac-8405f51b8d2c@redhat.com> Subject: Re: [Qemu-devel] [PATCH 3/6] qapi: add SysEmuTarget to "common.json" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Eric Blake Cc: Laszlo Ersek , qemu-devel@nongnu.org, David Gibson , Gerd Hoffmann , Kashyap Chamarthy , Markus Armbruster , Paolo Bonzini , Thomas Huth On Tue, Apr 24, 2018 at 06:11:05PM -0500, Eric Blake wrote: > On 04/24/2018 04:45 PM, Laszlo Ersek wrote: > > We'll soon need an enumeration type that lists all the softmmu targets > > that QEMU (the project) supports. Introduce @SysEmuTarget to > > "common.json". > > > > Cc: "Daniel P. Berrange" > > Cc: David Gibson > > Cc: Eric Blake > > Cc: Gerd Hoffmann > > Cc: Kashyap Chamarthy > > Cc: Markus Armbruster > > Cc: Paolo Bonzini > > Cc: Thomas Huth > > Signed-off-by: Laszlo Ersek > > Reviewed-by: Markus Armbruster > > Reviewed-by: Kashyap Chamarthy > > --- > > > > > +## > > +{ 'enum' : 'SysEmuTarget', > > + 'data' : [ 'aarch64', 'alpha', 'arm', 'cris', 'hppa', 'i386', 'lm32', > > + 'm68k', 'microblaze', 'microblazeel', 'mips', 'mips64', > > + 'mips64el', 'mipsel', 'moxie', 'nios2', 'or1k', 'ppc', > > + 'ppc64', 'ppcemb', 'riscv32', 'riscv64', 's390x', 'sh4', > > + 'sh4eb', 'sparc', 'sparc64', 'tricore', 'unicore32', > > + 'x86_64', 'xtensa', 'xtensaeb' ] } > > x86_64 doesn't match our typical conventions of preferring '-' over '_'; > also, wikipedia mentions both spellings but under the page name > 'x86-64'. Is it worth switching that enum constant? > > https://en.wikipedia.org/wiki/X86-64 I would not want that - SysEmuTarget is supposed to be correlated with the qemu-system-$TARGET binary names and we use qemu-system-x86_64 there. Regards, Daniel -- |: https://berrange.com -o- https://www.flickr.com/photos/dberrange :| |: https://libvirt.org -o- https://fstop138.berrange.com :| |: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|