From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Eduardo Habkost" <ehabkost@redhat.com>,
"Marcel Apfelbaum" <marcel@redhat.com>
Subject: [Qemu-devel] [RFC PATCH] hw/core: expand description of null-machine
Date: Wed, 25 Apr 2018 16:33:43 +0100 [thread overview]
Message-ID: <20180425153343.24023-1-alex.bennee@linaro.org> (raw)
People following old instructions for QEMU get the message "No machine
specified, and there is no default" and run -machine help to pick a
new machine. Lay people might consider the null-machine to be such a
basic starting point but they won't get far. This leads to confusion,
see https://bugs.launchpad.net/qemu/+bug/1766896 as an example.
I'm open to better words - I figured "THIS PROBABLY ISN'T WHAT YOU
WANT" seemed less helpful though.
Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
---
hw/core/null-machine.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/null-machine.c b/hw/core/null-machine.c
index cde4d3eb57..72f0815045 100644
--- a/hw/core/null-machine.c
+++ b/hw/core/null-machine.c
@@ -50,7 +50,7 @@ static void machine_none_init(MachineState *mch)
static void machine_none_machine_init(MachineClass *mc)
{
- mc->desc = "empty machine";
+ mc->desc = "empty machine (for probing/QMP)";
mc->init = machine_none_init;
mc->max_cpus = 1;
mc->default_ram_size = 0;
--
2.17.0
next reply other threads:[~2018-04-25 15:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 15:33 Alex Bennée [this message]
2018-04-25 15:52 ` [Qemu-devel] [RFC PATCH] hw/core: expand description of null-machine Thomas Huth
2018-04-26 16:09 ` Alex Bennée
2018-04-26 18:18 ` Thomas Huth
2018-04-26 18:31 ` Peter Maydell
2018-04-26 18:44 ` Alex Bennée
2018-04-26 18:53 ` Thomas Huth
2018-05-03 19:29 ` Eduardo Habkost
2018-04-26 18:55 ` Max Filippov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425153343.24023-1-alex.bennee@linaro.org \
--to=alex.bennee@linaro.org \
--cc=ehabkost@redhat.com \
--cc=marcel@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).