From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:52530) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fBMOw-0005hu-G8 for qemu-devel@nongnu.org; Wed, 25 Apr 2018 11:32:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fBMOo-00007i-MC for qemu-devel@nongnu.org; Wed, 25 Apr 2018 11:32:10 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:59546 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fBMOo-00006S-FU for qemu-devel@nongnu.org; Wed, 25 Apr 2018 11:32:02 -0400 Date: Wed, 25 Apr 2018 17:31:52 +0200 From: Igor Mammedov Message-ID: <20180425173152.4c2c1c4f@redhat.com> In-Reply-To: <20180425165847-mutt-send-email-mst@kernel.org> References: <1524524398-41342-1-git-send-email-mst@redhat.com> <20180424035504-mutt-send-email-mst@kernel.org> <20180424095722.76105b40@redhat.com> <20180424201554-mutt-send-email-mst@kernel.org> <20180424210040-mutt-send-email-mst@kernel.org> <20180425154938.78deea44@redhat.com> <20180425165847-mutt-send-email-mst@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH] acpi/nvdimm: remove forward name references List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: "Schmauss, Erik" , "qemu-devel@nongnu.org" , Xiao Guangrong , "Williams, Dan J" On Wed, 25 Apr 2018 17:17:04 +0300 "Michael S. Tsirkin" wrote: > On Wed, Apr 25, 2018 at 03:49:38PM +0200, Igor Mammedov wrote: > > On Tue, 24 Apr 2018 21:06:37 +0300 > > "Michael S. Tsirkin" wrote: > > > > > On Tue, Apr 24, 2018 at 05:47:58PM +0000, Schmauss, Erik wrote: > > > > > > > > > > > > > -----Original Message----- > > > > > From: Michael S. Tsirkin [mailto:mst@redhat.com] > > > > > Sent: Tuesday, April 24, 2018 10:43 AM > > > > > To: Igor Mammedov > > > > > Cc: Schmauss, Erik ; qemu-devel@nongnu.org; Xiao > > > > > Guangrong ; Williams, Dan J > > > > > > > > > > Subject: Re: [PATCH] acpi/nvdimm: remove forward name references > > > > > > > > > > On Tue, Apr 24, 2018 at 09:57:22AM +0200, Igor Mammedov wrote: > > > > > > On Tue, 24 Apr 2018 04:02:40 +0300 > > > > > > "Michael S. Tsirkin" wrote: > > > > > > [...] > > > > > > From spec > > > > > > DefOpRegion := OpRegionOp NameString RegionSpace RegionOffset > > > > > > RegionLen RegionOffset := TermArg => Integer TermArg := Type2Opcode > > > > > > | DataObject | ArgObj | LocalObj > > > > > > > > > > > > So named object is not accepted, > > > > > > > > > > might be worth checking what happens with actual OSPMs. > > > > > If it does happen to work, we can try tweaking the ACPI spec to allow this. > > > > > > > > I'm looking at the ACPI6.2a spec on page 840 and it says > > > > TermArg := Type2Opcode | DataObject | Argterm |LocalTerm |NameString |SymbolicExpression > > > > > > Oh right, that's there since ACPI 6.0. > > Strange, I've rechecked AML definition of TermArg in 6.0 and 6.2a > > and it still says only > > > > TermArg := Type2Opcode | DataObject | ArgObj | LocalObj > > > > For 6.2a, I'm looking at chapter "20.2.5 Term Objects Encoding" > > where exactly do you guys see that longer variant? > > Oh interesting. That's in > 19.2.3 ASL Root and Secondary Terms > > How come it's not the same? bugs are everywhere, see "20.2.5 Term Objects Encoding" > > > > > > As usual, the issue is that > > > we can't easily check what does OSPM support. > > > This is really something worth fixing in the spec IMHO. > > > We could just try and test a bunch of guest OSPMs and if > > > they happen to work, switch to that. Lots of work for > > > uncertain benefit. > > I think some windows versions weren't happy with it when > > we were trying to use dynamic operation regions with offset > > as namestring. > > > Good to know, thanks. I'll try to retest MS VMs I have here, to see which one breaks.