[Qemu-devel] [PATCH 0/8] block: more byte-based cleanups: vectored I/O

[Qemu-devel] [PATCH 0/8] block: more byte-based cleanups: vectored I/O

[Eric Blake]

In my continuing quest to nuke pointless sector-based interfaces,
here's another round of cleanups.  I spent some time on qcow,
then was appalled at how long iotests took to prove that it did
not regress; so for parallels, replication, and vhdx, I'll leave
any further cleanups within those files to interested owners.

There are now very few remaining calls into bdrv_{read,write}, so
that will be my next cleanup.

Eric Blake (8):
  parallels: Switch to byte-based calls
  qcow: Switch get_cluster_offset to be byte-based
  qcow: Switch qcow_co_readv to byte-based calls
  qcow: Switch qcow_co_writev to byte-based calls
  qcow: Switch to a byte-based driver
  replication: Switch to byte-based calls
  vhdx: Switch to byte-based calls
  block: Removed unused sector-based vectored I/O

 include/block/block.h |   4 --
 block/io.c            |  36 ---------------
 block/parallels.c     |  16 ++++---
 block/qcow.c          | 122 +++++++++++++++++++++++++-------------------------
 block/replication.c   |  14 +++---
 block/vhdx.c          |  12 ++---
 6 files changed, 86 insertions(+), 118 deletions(-)

-- 
2.14.3

[Qemu-devel] [PATCH 0/8] block: more byte-based cleanups: vectored I/O

[Eric Blake]

Based-on: <20180424192506.149089-1-eblake@redhat.com>
([PATCH v2 0/6] block: byte-based AIO read/write)
Based-on: <20180424220157.177385-1-eblake@redhat.com>
([PATCH] block: Merge .bdrv_co_writev{, _flags} in drivers)

My quest continues.  I spent some time pruning qcow down as far
as possible (and was dismayed at how long it took to prove no
iotests regressions); so for the other drivers, I did the bare
minimum to get rid of an interface, but will leave it to those
file owners if they want to get rid of further pointless sector
manipulations in their files.

Next on the chopping block: bdrv_read/bdrv_write.

Eric Blake (8):
  parallels: Switch to byte-based calls
  qcow: Switch get_cluster_offset to be byte-based
  qcow: Switch qcow_co_readv to byte-based calls
  qcow: Switch qcow_co_writev to byte-based calls
  qcow: Switch to a byte-based driver
  replication: Switch to byte-based calls
  vhdx: Switch to byte-based calls
  block: Removed unused sector-based vectored I/O

 include/block/block.h |   4 --
 block/io.c            |  36 ---------------
 block/parallels.c     |  16 ++++---
 block/qcow.c          | 122 +++++++++++++++++++++++++-------------------------
 block/replication.c   |  14 +++---
 block/vhdx.c          |  12 ++---
 6 files changed, 86 insertions(+), 118 deletions(-)

-- 
2.14.3

Re: [Qemu-devel] [PATCH 0/8] block: more byte-based cleanups: vectored I/O

[Eric Blake]

[-- Attachment #1: Type: text/plain, Size: 792 bytes --]

On 04/25/2018 01:19 PM, Eric Blake wrote:
> In my continuing quest to nuke pointless sector-based interfaces,
> here's another round of cleanups.  I spent some time on qcow,
> then was appalled at how long iotests took to prove that it did
> not regress; so for parallels, replication, and vhdx, I'll leave
> any further cleanups within those files to interested owners.
> 
> There are now very few remaining calls into bdrv_{read,write}, so
> that will be my next cleanup.

Ignore this one; I sent a cover letter prematurely, before I added
Based-on tags for the real series:
https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg04444.html


-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 619 bytes --]

Re: [Qemu-devel] [PATCH 0/8] block: more byte-based cleanups: vectored I/O

[Kevin Wolf]

Am 25.04.2018 um 20:32 hat Eric Blake geschrieben:
> Based-on: <20180424192506.149089-1-eblake@redhat.com>
> ([PATCH v2 0/6] block: byte-based AIO read/write)
> Based-on: <20180424220157.177385-1-eblake@redhat.com>
> ([PATCH] block: Merge .bdrv_co_writev{, _flags} in drivers)
> 
> My quest continues.  I spent some time pruning qcow down as far
> as possible (and was dismayed at how long it took to prove no
> iotests regressions); so for the other drivers, I did the bare
> minimum to get rid of an interface, but will leave it to those
> file owners if they want to get rid of further pointless sector
> manipulations in their files.
> 
> Next on the chopping block: bdrv_read/bdrv_write.

Nice series, looks good apart from a few minor comments on the qcow1
conversion.

For v2, can you please make sure to have proper CCs also on the cover
letter?

Kevin

Re: [Qemu-devel] [PATCH 0/8] block: more byte-based cleanups: vectored I/O

[Eric Blake]

On 05/28/2018 06:19 AM, Kevin Wolf wrote:
> Am 25.04.2018 um 20:32 hat Eric Blake geschrieben:
>> Based-on: <20180424192506.149089-1-eblake@redhat.com>
>> ([PATCH v2 0/6] block: byte-based AIO read/write)
>> Based-on: <20180424220157.177385-1-eblake@redhat.com>
>> ([PATCH] block: Merge .bdrv_co_writev{, _flags} in drivers)
>>
>> My quest continues.  I spent some time pruning qcow down as far
>> as possible (and was dismayed at how long it took to prove no
>> iotests regressions); so for the other drivers, I did the bare
>> minimum to get rid of an interface, but will leave it to those
>> file owners if they want to get rid of further pointless sector
>> manipulations in their files.
>>
>> Next on the chopping block: bdrv_read/bdrv_write.
> 
> Nice series, looks good apart from a few minor comments on the qcow1
> conversion.

For qcow1, I kept things at 512-byte alignment throughout; as the format 
is not for new users, I find it easier to assert that things are aligned 
than to worry about sub-sector requests.  But yes, I can improve things 
according to your comments for v2.

> 
> For v2, can you please make sure to have proper CCs also on the cover
> letter?

Does git-publish do this automatically?  (If so, it's time for me to 
start using it...)

-- 
Eric Blake, Principal Software Engineer
Red Hat, Inc.           +1-919-301-3266
Virtualization:  qemu.org | libvirt.org