From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: Wen Congyang <wencongyang2@huawei.com>,
Xie Changlong <xiechanglong.d@gmail.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
"open list:Block layer core" <qemu-block@nongnu.org>
Subject: [Qemu-devel] [PATCH 6/8] replication: Switch to byte-based calls
Date: Wed, 25 Apr 2018 13:32:21 -0500 [thread overview]
Message-ID: <20180425183223.580566-7-eblake@redhat.com> (raw)
In-Reply-To: <20180425183223.580566-1-eblake@redhat.com>
We are gradually moving away from sector-based interfaces, towards
byte-based. Make the change for the last few sector-based calls
into the block layer from the replication driver.
Ideally, the replication driver should switch to doing everything
byte-based, but that's a more invasive change that requires a
bit more auditing.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
block/replication.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/block/replication.c b/block/replication.c
index 48148b884a5..131639d0714 100644
--- a/block/replication.c
+++ b/block/replication.c
@@ -246,13 +246,14 @@ static coroutine_fn int replication_co_readv(BlockDriverState *bs,
backup_cow_request_begin(&req, child->bs->job,
sector_num * BDRV_SECTOR_SIZE,
remaining_bytes);
- ret = bdrv_co_readv(bs->file, sector_num, remaining_sectors,
- qiov);
+ ret = bdrv_co_preadv(bs->file, sector_num * BDRV_SECTOR_SIZE,
+ remaining_bytes, qiov, 0);
backup_cow_request_end(&req);
goto out;
}
- ret = bdrv_co_readv(bs->file, sector_num, remaining_sectors, qiov);
+ ret = bdrv_co_preadv(bs->file, sector_num * BDRV_SECTOR_SIZE,
+ remaining_sectors * BDRV_SECTOR_SIZE, qiov, 0);
out:
return replication_return_value(s, ret);
}
@@ -279,8 +280,8 @@ static coroutine_fn int replication_co_writev(BlockDriverState *bs,
}
if (ret == 0) {
- ret = bdrv_co_writev(top, sector_num,
- remaining_sectors, qiov);
+ ret = bdrv_co_pwritev(top, sector_num * BDRV_SECTOR_SIZE,
+ remaining_sectors * BDRV_SECTOR_SIZE, qiov, 0);
return replication_return_value(s, ret);
}
@@ -306,7 +307,8 @@ static coroutine_fn int replication_co_writev(BlockDriverState *bs,
qemu_iovec_concat(&hd_qiov, qiov, bytes_done, count);
target = ret ? top : base;
- ret = bdrv_co_writev(target, sector_num, n, &hd_qiov);
+ ret = bdrv_co_pwritev(target, sector_num * BDRV_SECTOR_SIZE,
+ n * BDRV_SECTOR_SIZE, &hd_qiov, 0);
if (ret < 0) {
goto out1;
}
--
2.14.3
next prev parent reply other threads:[~2018-04-25 18:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 18:32 [Qemu-devel] [PATCH 0/8] block: more byte-based cleanups: vectored I/O Eric Blake
2018-04-25 18:32 ` [Qemu-devel] [PATCH 1/8] parallels: Switch to byte-based calls Eric Blake
2018-05-23 19:19 ` [Qemu-devel] [Qemu-block] " John Snow
2018-05-23 20:09 ` Eric Blake
2018-05-23 20:10 ` John Snow
2018-05-25 15:22 ` [Qemu-devel] " Stefan Hajnoczi
2018-05-25 16:29 ` Denis V. Lunev
2018-04-25 18:32 ` [Qemu-devel] [PATCH 2/8] qcow: Switch get_cluster_offset to be byte-based Eric Blake
2018-05-28 10:52 ` Kevin Wolf
2018-05-29 15:03 ` Eric Blake
2018-05-29 15:10 ` Kevin Wolf
2018-04-25 18:32 ` [Qemu-devel] [PATCH 3/8] qcow: Switch qcow_co_readv to byte-based calls Eric Blake
2018-05-28 11:04 ` Kevin Wolf
2018-05-29 15:03 ` Eric Blake
2018-04-25 18:32 ` [Qemu-devel] [PATCH 4/8] qcow: Switch qcow_co_writev " Eric Blake
2018-05-28 11:09 ` Kevin Wolf
2018-04-25 18:32 ` [Qemu-devel] [PATCH 5/8] qcow: Switch to a byte-based driver Eric Blake
2018-04-25 18:32 ` Eric Blake [this message]
2018-04-25 18:32 ` [Qemu-devel] [PATCH 7/8] vhdx: Switch to byte-based calls Eric Blake
2018-04-25 18:32 ` [Qemu-devel] [PATCH 8/8] block: Removed unused sector-based vectored I/O Eric Blake
2018-05-25 15:22 ` Stefan Hajnoczi
2018-05-28 11:19 ` [Qemu-devel] [PATCH 0/8] block: more byte-based cleanups: " Kevin Wolf
2018-05-29 15:00 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180425183223.580566-7-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=wencongyang2@huawei.com \
--cc=xiechanglong.d@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).