qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, mreitz@redhat.com, berto@igalia.com,
	qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH v6 0/6] minor qcow2 compression improvements
Date: Wed, 25 Apr 2018 21:51:23 -0500	[thread overview]
Message-ID: <20180426025129.621969-1-eblake@redhat.com> (raw)

Even though v5 was posted earlier today, it was worth a respin:
- 2/6: add R-b [Berto]
- 4/6, 6/6: improve commit messages [Max]
- 5/6: new patch, with an iotests proving that 4/6 is a bug fix [Max]

The new test is rather slow (nearly 90 seconds for me using
tmpfs) unless it skips entirely (such as testing on ext4); ideas
for speeding it up are welcome (translation: maybe qemu should
optimize the search for the next available cluster to allocate,
and/or qemu-img check should be faster at reporting leaked
clusters)

001/6:[----] [--] 'qcow2: Prefer byte-based calls into bs->file'
002/6:[----] [--] 'qcow2: Document some maximum size constraints'
003/6:[----] [--] 'qcow2: Reduce REFT_OFFSET_MASK'
004/6:[----] [--] 'qcow2: Don't allow overflow during cluster allocation'
005/6:[down] 'iotests: Add new test 214 for max compressed cluster offset'
006/6:[----] [--] 'qcow2: Avoid memory over-allocation on compressed images'

Eric Blake (6):
  qcow2: Prefer byte-based calls into bs->file
  qcow2: Document some maximum size constraints
  qcow2: Reduce REFT_OFFSET_MASK
  qcow2: Don't allow overflow during cluster allocation
  iotests: Add new test 214 for max compressed cluster offset
  qcow2: Avoid memory over-allocation on compressed images

 docs/interop/qcow2.txt     | 40 +++++++++++++++++--
 block/qcow2.h              |  8 +++-
 block/qcow2-cluster.c      | 32 +++++++++------
 block/qcow2-refcount.c     | 27 ++++++++-----
 block/qcow2.c              |  2 +-
 tests/qemu-iotests/214     | 97 ++++++++++++++++++++++++++++++++++++++++++++++
 tests/qemu-iotests/214.out | 54 ++++++++++++++++++++++++++
 tests/qemu-iotests/group   |  1 +
 8 files changed, 234 insertions(+), 27 deletions(-)
 create mode 100755 tests/qemu-iotests/214
 create mode 100644 tests/qemu-iotests/214.out

-- 
2.14.3

             reply	other threads:[~2018-04-26  2:51 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-26  2:51 Eric Blake [this message]
2018-04-26  2:51 ` [Qemu-devel] [PATCH v6 1/6] qcow2: Prefer byte-based calls into bs->file Eric Blake
2018-04-26  2:51 ` [Qemu-devel] [PATCH v6 2/6] qcow2: Document some maximum size constraints Eric Blake
2018-04-26  2:51 ` [Qemu-devel] [PATCH v6 3/6] qcow2: Reduce REFT_OFFSET_MASK Eric Blake
2018-04-26  2:51 ` [Qemu-devel] [PATCH v6 4/6] qcow2: Don't allow overflow during cluster allocation Eric Blake
2018-04-26  2:51 ` [Qemu-devel] [PATCH v6 5/6] iotests: Add new test 214 for max compressed cluster offset Eric Blake
2018-04-26 12:10   ` Alberto Garcia
2018-06-19 18:51     ` Eric Blake
2018-06-20 12:10       ` Alberto Garcia
2018-04-26  2:51 ` [Qemu-devel] [PATCH v6 6/6] qcow2: Avoid memory over-allocation on compressed images Eric Blake
2018-06-19 18:49 ` [Qemu-devel] [PATCH v6 0/6] minor qcow2 compression improvements Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180426025129.621969-1-eblake@redhat.com \
    --to=eblake@redhat.com \
    --cc=berto@igalia.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).