From: Eduardo Habkost <ehabkost@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Thomas Huth <thuth@redhat.com>, Cornelia Huck <cohuck@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org,
David Hildenbrand <david@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>
Subject: Re: [Qemu-devel] [RFC PATCH] hw/s390x: Allow to configure the consoles with the "-serial" parameter
Date: Thu, 26 Apr 2018 20:55:15 -0300 [thread overview]
Message-ID: <20180426235515.GL29865@localhost.localdomain> (raw)
In-Reply-To: <64848d8f-071d-e6c8-58a7-d1e74e93e4f0@redhat.com>
On Tue, Apr 24, 2018 at 06:19:35PM +0200, Paolo Bonzini wrote:
> On 24/04/2018 16:22, Thomas Huth wrote:
> > $ diff -u sclp-qom-tree-before.txt sclp-qom-tree-after.txt
> > --- sclp-qom-tree-before.txt 2018-04-24 16:17:48.462849585 +0200
> > +++ sclp-qom-tree-after.txt 2018-04-24 16:18:02.222820256 +0200
> > @@ -1,13 +1,14 @@
> > -(qemu) info qom-tree
> > +(qemu) info qom-tree
> > /machine (s390-ccw-virtio-2.12-machine)
> > /unattached (container)
> > - /system[0] (qemu:memory-region)
> > /sysbus (System)
> > - /device[1] (virtio-net-ccw)
> > + /device[0] (qemu-s390x-cpu)
> > + /s390.ram[0] (qemu:memory-region)
> > + /device[1] (sclpconsole)
> > + /device[2] (virtio-net-ccw)
> > /virtio-backend (virtio-net-device)
> > /virtio-bus (virtio-ccw-bus)
> > - /s390.ram[0] (qemu:memory-region)
> > - /device[0] (qemu-s390x-cpu)
> > + /system[0] (qemu:memory-region)
> > /io[0] (qemu:memory-region)
> > /sclp (sclp)
> > /s390-sclp-event-facility (s390-sclp-event-facility)
> > @@ -17,7 +18,6 @@
> > /s390-flic-qemu (s390-flic-qemu)
> > /s390-skeys (s390-skeys-qemu)
> > /peripheral-anon (container)
> > - /device[0] (sclpconsole)
> > /peripheral (container)
> > /s390-ipl (s390-ipl)
> > /virtual-css-bridge (virtual-css-bridge)
> >
> > ... the sclpconsole now shows up under /unattached instead of
> > /peripheral-anon ... does that matter? (I don't have a clue)
>
> If the devices are created in the same order, before and after the
> patch, it should be okay.
Is there a way to find out if the devices are created in the same
order using only QMP commands? It would be very useful to
automatically validate compatibility between QEMU versions.
--
Eduardo
next prev parent reply other threads:[~2018-04-26 23:55 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-24 11:44 [Qemu-devel] [RFC PATCH] hw/s390x: Allow to configure the consoles with the "-serial" parameter Thomas Huth
2018-04-24 11:49 ` Christian Borntraeger
2018-04-24 14:02 ` Thomas Huth
2018-04-24 14:09 ` Cornelia Huck
2018-04-24 14:22 ` Thomas Huth
2018-04-24 14:37 ` Cornelia Huck
2018-04-24 16:19 ` Paolo Bonzini
2018-04-26 23:55 ` Eduardo Habkost [this message]
2018-04-30 13:23 ` Paolo Bonzini
2018-04-24 18:09 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180426235515.GL29865@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@redhat.com \
--cc=marcel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).