From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: martin@schrodt.org, Gerd Hoffmann <kraxel@redhat.com>
Subject: [Qemu-devel] [PATCH v2 2/4] audio/hda: turn some dprintfs into trace points
Date: Fri, 27 Apr 2018 14:19:49 +0200 [thread overview]
Message-ID: <20180427121951.29769-3-kraxel@redhat.com> (raw)
In-Reply-To: <20180427121951.29769-1-kraxel@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
hw/audio/hda-codec.c | 9 ++++-----
hw/audio/trace-events | 4 ++++
2 files changed, 8 insertions(+), 5 deletions(-)
diff --git a/hw/audio/hda-codec.c b/hw/audio/hda-codec.c
index 9ee2f3d55f..13d4473f18 100644
--- a/hw/audio/hda-codec.c
+++ b/hw/audio/hda-codec.c
@@ -24,6 +24,7 @@
#include "intel-hda.h"
#include "intel-hda-defs.h"
#include "audio/audio.h"
+#include "trace.h"
/* -------------------------------------------------------------------------- */
@@ -394,8 +395,7 @@ static void hda_audio_set_running(HDAAudioStream *st, bool running)
return;
}
st->running = running;
- dprint(st->state, 1, "%s: %s (stream %d)\n", st->node->name,
- st->running ? "on" : "off", st->stream);
+ trace_hda_audio_running(st->node->name, st->stream, st->running);
if (st->state->use_timer) {
if (running) {
int64_t now = qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL);
@@ -449,9 +449,8 @@ static void hda_audio_setup(HDAAudioStream *st)
return;
}
- dprint(st->state, 1, "%s: format: %d x %s @ %d Hz\n",
- st->node->name, st->as.nchannels,
- fmt2name[st->as.fmt], st->as.freq);
+ trace_hda_audio_format(st->node->name, st->as.nchannels,
+ fmt2name[st->as.fmt], st->as.freq);
if (st->output) {
if (use_timer) {
diff --git a/hw/audio/trace-events b/hw/audio/trace-events
index fa1646d169..03340b9359 100644
--- a/hw/audio/trace-events
+++ b/hw/audio/trace-events
@@ -17,3 +17,7 @@ milkymist_ac97_in_cb(int avail, uint32_t remaining) "avail %d remaining %u"
milkymist_ac97_in_cb_transferred(int transferred) "transferred %d"
milkymist_ac97_out_cb(int free, uint32_t remaining) "free %d remaining %u"
milkymist_ac97_out_cb_transferred(int transferred) "transferred %d"
+
+# hw/audio/hda-codec.c
+hda_audio_running(const char *stream, int nr, bool running) "st %s, nr %d, run %d"
+hda_audio_format(const char *stream, int chan, const char *fmt, int freq) "st %s, %d x %s @ %d Hz"
--
2.9.3
next prev parent reply other threads:[~2018-04-27 12:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 12:19 [Qemu-devel] [PATCH v2 0/4] audio/hda: improve windows guest audio quality Gerd Hoffmann
2018-04-27 12:19 ` [Qemu-devel] [PATCH v2 1/4] audio/hda: create millisecond timers that handle IO Gerd Hoffmann
2018-04-27 12:19 ` Gerd Hoffmann [this message]
2018-04-27 12:19 ` [Qemu-devel] [PATCH v2 3/4] audio/hda: tweak timer adjust logic Gerd Hoffmann
2018-04-27 12:19 ` [Qemu-devel] [PATCH v2 4/4] audio/hda: detect output buffer overruns Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427121951.29769-3-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=martin@schrodt.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).