From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40779) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fC4EN-0003n5-5E for qemu-devel@nongnu.org; Fri, 27 Apr 2018 10:20:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fC4EI-0003g2-6R for qemu-devel@nongnu.org; Fri, 27 Apr 2018 10:20:11 -0400 From: Vladimir Sementsov-Ogievskiy Date: Fri, 27 Apr 2018 17:20:01 +0300 Message-Id: <20180427142002.21930-2-vsementsov@virtuozzo.com> In-Reply-To: <20180427142002.21930-1-vsementsov@virtuozzo.com> References: <20180427142002.21930-1-vsementsov@virtuozzo.com> Subject: [Qemu-devel] [PATCH 1/2] nbd/client: fix nbd_negotiate_simple_meta_context List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-stable@nongnu.org Cc: eblake@redhat.com, pbonzini@redhat.com, dgilbert@redhat.com, quintela@redhat.com, famz@redhat.com, stefanha@redhat.com, vsementsov@virtuozzo.com, den@openvz.org, peter.maydell@linaro.org Initialize received variable. Otherwise, is is possible for server to answer without any contexts, but we will set context_id to something random (received_id is not initialized too) and return 1, which is wrong. To solve it, just initialize received to false. Initialize received_id too, just to make all possible checkers happy. But was introduced in 78a33ab58782efdb206de14 "nbd: BLOCK_STATUS for standard get_block_status function: client part" with the whole function. Signed-off-by: Vladimir Sementsov-Ogievskiy --- nbd/client.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nbd/client.c b/nbd/client.c index b9e175d1c2..7f35b5c323 100644 --- a/nbd/client.c +++ b/nbd/client.c @@ -613,8 +613,8 @@ static int nbd_negotiate_simple_meta_context(QIOChannel *ioc, { int ret; NBDOptionReply reply; - uint32_t received_id; - bool received; + uint32_t received_id = 0; + bool received = false; uint32_t export_len = strlen(export); uint32_t context_len = strlen(context); uint32_t data_len = sizeof(export_len) + export_len + -- 2.11.1