From: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
To: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-stable@nongnu.org
Cc: eblake@redhat.com, pbonzini@redhat.com, dgilbert@redhat.com,
quintela@redhat.com, famz@redhat.com, stefanha@redhat.com,
vsementsov@virtuozzo.com, den@openvz.org,
peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 2/2] migration/block-dirty-bitmap: fix memory leak in dirty_bitmap_load_bits
Date: Fri, 27 Apr 2018 17:20:02 +0300 [thread overview]
Message-ID: <20180427142002.21930-3-vsementsov@virtuozzo.com> (raw)
In-Reply-To: <20180427142002.21930-1-vsementsov@virtuozzo.com>
Release buf on error path too.
Bug was introduced in b35ebdf076d697bc "migration: add postcopy
migration of dirty bitmaps" with the whole function.
Signed-off-by: Vladimir Sementsov-Ogievskiy <vsementsov@virtuozzo.com>
---
migration/block-dirty-bitmap.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/migration/block-dirty-bitmap.c b/migration/block-dirty-bitmap.c
index dd04f102d8..8819aabe3a 100644
--- a/migration/block-dirty-bitmap.c
+++ b/migration/block-dirty-bitmap.c
@@ -600,6 +600,7 @@ static int dirty_bitmap_load_bits(QEMUFile *f, DirtyBitmapLoadState *s)
ret = qemu_get_buffer(f, buf, buf_size);
if (ret != buf_size) {
error_report("Failed to read bitmap bits");
+ g_free(buf);
return -EIO;
}
--
2.11.1
next prev parent reply other threads:[~2018-04-27 14:20 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 14:20 [Qemu-devel] [PATCH 0/2] fix coverity bugs Vladimir Sementsov-Ogievskiy
2018-04-27 14:20 ` [Qemu-devel] [PATCH 1/2] nbd/client: fix nbd_negotiate_simple_meta_context Vladimir Sementsov-Ogievskiy
2018-04-27 15:20 ` Eric Blake
2018-04-27 14:20 ` Vladimir Sementsov-Ogievskiy [this message]
2018-04-27 15:19 ` [Qemu-devel] [PATCH 0/2] fix coverity bugs Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180427142002.21930-3-vsementsov@virtuozzo.com \
--to=vsementsov@virtuozzo.com \
--cc=den@openvz.org \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=famz@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
--cc=quintela@redhat.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).