From: Pavel Dovgalyuk <Pavel.Dovgaluk@ispras.ru>
To: qemu-devel@nongnu.org
Cc: kwolf@redhat.com, peter.maydell@linaro.org, war2jordan@live.com,
crosthwaite.peter@gmail.com, boost.lists@gmail.com,
quintela@redhat.com, ciro.santilli@gmail.com,
jasowang@redhat.com, mst@redhat.com, zuban32s@gmail.com,
armbru@redhat.com, maria.klimushenkova@ispras.ru,
dovgaluk@ispras.ru, kraxel@redhat.com, pavel.dovgaluk@ispras.ru,
thomas.dullien@googlemail.com, pbonzini@redhat.com,
mreitz@redhat.com, alex.bennee@linaro.org, dgilbert@redhat.com,
rth@twiddle.net
Subject: [Qemu-devel] [RFC PATCH v2 01/19] block: implement bdrv_snapshot_goto for blkreplay
Date: Sat, 28 Apr 2018 15:36:34 +0300 [thread overview]
Message-ID: <20180428123634.12445.90565.stgit@pasha-VirtualBox> (raw)
In-Reply-To: <20180428123627.12445.9923.stgit@pasha-VirtualBox>
From: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
This patch enables making snapshots with blkreplay used in
block devices.
This function is required to make bdrv_snapshot_goto without
calling .bdrv_open which is not implemented.
Signed-off-by: Pavel Dovgalyuk <pavel.dovgaluk@ispras.ru>
---
block/blkreplay.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/block/blkreplay.c b/block/blkreplay.c
index fe5a9b4..ec0aa82 100755
--- a/block/blkreplay.c
+++ b/block/blkreplay.c
@@ -127,6 +127,12 @@ static int coroutine_fn blkreplay_co_flush(BlockDriverState *bs)
return ret;
}
+static int blkreplay_snapshot_goto(BlockDriverState *bs,
+ const char *snapshot_id)
+{
+ return bdrv_snapshot_goto(bs->file->bs, snapshot_id, NULL);
+}
+
static BlockDriver bdrv_blkreplay = {
.format_name = "blkreplay",
.instance_size = 0,
@@ -142,6 +148,8 @@ static BlockDriver bdrv_blkreplay = {
.bdrv_co_pwrite_zeroes = blkreplay_co_pwrite_zeroes,
.bdrv_co_pdiscard = blkreplay_co_pdiscard,
.bdrv_co_flush = blkreplay_co_flush,
+
+ .bdrv_snapshot_goto = blkreplay_snapshot_goto,
};
static void bdrv_blkreplay_init(void)
next prev parent reply other threads:[~2018-04-28 12:36 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-28 12:36 [Qemu-devel] [RFC PATCH v2 00/19] reverse debugging Pavel Dovgalyuk
2018-04-28 12:36 ` Pavel Dovgalyuk [this message]
2018-04-28 12:36 ` [Qemu-devel] [RFC PATCH v2 02/19] replay: disable default snapshot for record/replay Pavel Dovgalyuk
2018-04-28 12:36 ` [Qemu-devel] [RFC PATCH v2 03/19] replay: update docs for record/replay with block devices Pavel Dovgalyuk
2018-04-28 12:36 ` [Qemu-devel] [RFC PATCH v2 04/19] replay: don't drain/flush bdrv queue while RR is working Pavel Dovgalyuk
2018-04-28 12:36 ` [Qemu-devel] [RFC PATCH v2 05/19] replay: finish record/replay before closing the disks Pavel Dovgalyuk
2018-04-28 12:37 ` [Qemu-devel] [RFC PATCH v2 06/19] qcow2: introduce icount field for snapshots Pavel Dovgalyuk
2018-04-28 12:37 ` [Qemu-devel] [RFC PATCH v2 07/19] migration: " Pavel Dovgalyuk
2018-04-28 12:37 ` [Qemu-devel] [RFC PATCH v2 08/19] replay: introduce info hmp/qmp command Pavel Dovgalyuk
2018-04-28 12:37 ` [Qemu-devel] [RFC PATCH v2 09/19] replay: introduce breakpoint at the specified step Pavel Dovgalyuk
2018-04-28 12:37 ` [Qemu-devel] [RFC PATCH v2 10/19] replay: implement replay-seek command to proceed to the desired step Pavel Dovgalyuk
2018-04-28 12:37 ` [Qemu-devel] [RFC PATCH v2 11/19] replay: flush events when exitting Pavel Dovgalyuk
2018-04-30 16:18 ` Eric Blake
2018-04-28 12:37 ` [Qemu-devel] [RFC PATCH v2 12/19] timer: remove replay clock probe in deadline calculation Pavel Dovgalyuk
2018-04-28 12:37 ` [Qemu-devel] [RFC PATCH v2 13/19] replay: refine replay-time module Pavel Dovgalyuk
2018-04-28 12:37 ` [Qemu-devel] [RFC PATCH v2 14/19] translator: fix breakpoint processing Pavel Dovgalyuk
2018-04-28 12:37 ` [Qemu-devel] [RFC PATCH v2 15/19] replay: flush rr queue before loading the vmstate Pavel Dovgalyuk
2018-04-28 12:38 ` [Qemu-devel] [RFC PATCH v2 16/19] gdbstub: add reverse step support in replay mode Pavel Dovgalyuk
2018-04-28 12:38 ` [Qemu-devel] [RFC PATCH v2 17/19] gdbstub: add reverse continue " Pavel Dovgalyuk
2018-04-28 12:38 ` [Qemu-devel] [RFC PATCH v2 18/19] replay: describe reverse debugging in docs/replay.txt Pavel Dovgalyuk
2018-04-28 12:38 ` [Qemu-devel] [RFC PATCH v2 19/19] replay: allow loading any snapshots before recording Pavel Dovgalyuk
2018-04-30 14:19 ` [Qemu-devel] [RFC PATCH v2 00/19] reverse debugging Ciro Santilli
2018-04-30 14:24 ` Pavel Dovgalyuk
2018-05-11 8:32 ` Pavel Dovgalyuk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180428123634.12445.90565.stgit@pasha-VirtualBox \
--to=pavel.dovgaluk@ispras.ru \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=boost.lists@gmail.com \
--cc=ciro.santilli@gmail.com \
--cc=crosthwaite.peter@gmail.com \
--cc=dgilbert@redhat.com \
--cc=dovgaluk@ispras.ru \
--cc=jasowang@redhat.com \
--cc=kraxel@redhat.com \
--cc=kwolf@redhat.com \
--cc=maria.klimushenkova@ispras.ru \
--cc=mreitz@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=quintela@redhat.com \
--cc=rth@twiddle.net \
--cc=thomas.dullien@googlemail.com \
--cc=war2jordan@live.com \
--cc=zuban32s@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).