qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
To: qemu-devel@nongnu.org
Cc: marcel.apfelbaum@gmail.com, yuval.shaia@oracle.com,
	peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 6/7] hw/rdma: Delete duplicate definition of MAX_RM_TBL_NAME
Date: Mon, 30 Apr 2018 23:02:22 +0300	[thread overview]
Message-ID: <20180430200223.4119-7-marcel.apfelbaum@gmail.com> (raw)
In-Reply-To: <20180430200223.4119-1-marcel.apfelbaum@gmail.com>

From: Yuval Shaia <yuval.shaia@oracle.com>

By a mistake this constant was defined twice - remove the duplication.

Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
---
 hw/rdma/rdma_rm.c      | 2 --
 hw/rdma/rdma_rm_defs.h | 4 ++--
 2 files changed, 2 insertions(+), 4 deletions(-)

diff --git a/hw/rdma/rdma_rm.c b/hw/rdma/rdma_rm.c
index 51a47d7292..415da15efe 100644
--- a/hw/rdma/rdma_rm.c
+++ b/hw/rdma/rdma_rm.c
@@ -21,8 +21,6 @@
 #include "rdma_backend.h"
 #include "rdma_rm.h"
 
-#define MAX_RM_TBL_NAME 16
-
 /* Page directory and page tables */
 #define PG_DIR_SZ { TARGET_PAGE_SIZE / sizeof(__u64) }
 #define PG_TBL_SZ { TARGET_PAGE_SIZE / sizeof(__u64) }
diff --git a/hw/rdma/rdma_rm_defs.h b/hw/rdma/rdma_rm_defs.h
index 4d22a20e4c..226011176d 100644
--- a/hw/rdma/rdma_rm_defs.h
+++ b/hw/rdma/rdma_rm_defs.h
@@ -34,9 +34,9 @@
 #define MAX_QP_INIT_RD_ATOM   16
 #define MAX_AH                64
 
-#define MAX_RMRESTBL_NAME_SZ 16
+#define MAX_RM_TBL_NAME 16
 typedef struct RdmaRmResTbl {
-    char name[MAX_RMRESTBL_NAME_SZ];
+    char name[MAX_RM_TBL_NAME];
     QemuMutex lock;
     unsigned long *bitmap;
     size_t tbl_sz;
-- 
2.14.3

  parent reply	other threads:[~2018-04-30 20:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 20:02 [Qemu-devel] [PATCH 0/7] hw/rdma: coverity fixes Marcel Apfelbaum
2018-04-30 20:02 ` [Qemu-devel] [PATCH 1/7] hw/rdma: Fix possible munmap call on a NULL pointer Marcel Apfelbaum
2018-04-30 20:02 ` [Qemu-devel] [PATCH 2/7] hw/rdma: Fix possible usage of " Marcel Apfelbaum
2018-05-01  3:04   ` Philippe Mathieu-Daudé
2018-04-30 20:02 ` [Qemu-devel] [PATCH 3/7] hw/rdma: Delete port's pkey table Marcel Apfelbaum
2018-04-30 20:02 ` [Qemu-devel] [PATCH 4/7] hw/rdma: Fix possible out of bounds access to GID table Marcel Apfelbaum
2018-04-30 20:02 ` [Qemu-devel] [PATCH 5/7] hw/rdma: Fix possible out of bounds access to regs array Marcel Apfelbaum
2018-04-30 20:02 ` Marcel Apfelbaum [this message]
2018-04-30 20:02 ` [Qemu-devel] [PATCH 7/7] hw/rdma: Fix possible out of bounds access to port GID index Marcel Apfelbaum
2018-04-30 21:14   ` Eric Blake
2018-05-01  8:58     ` Marcel Apfelbaum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180430200223.4119-7-marcel.apfelbaum@gmail.com \
    --to=marcel.apfelbaum@gmail.com \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=yuval.shaia@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).