From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
To: qemu-devel@nongnu.org
Cc: marcel.apfelbaum@gmail.com, yuval.shaia@oracle.com,
peter.maydell@linaro.org
Subject: [Qemu-devel] [PATCH 7/7] hw/rdma: Fix possible out of bounds access to port GID index
Date: Mon, 30 Apr 2018 23:02:23 +0300 [thread overview]
Message-ID: <20180430200223.4119-8-marcel.apfelbaum@gmail.com> (raw)
In-Reply-To: <20180430200223.4119-1-marcel.apfelbaum@gmail.com>
Make sure the backend GID index is less then port's
git table length.
Signed-off-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Reviewed-by: Yuval Shaia <yuval.shaia@oracle.com>
---
hw/rdma/rdma_backend.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/rdma/rdma_backend.c b/hw/rdma/rdma_backend.c
index 5c7b3d8949..e9ced6f9ef 100644
--- a/hw/rdma/rdma_backend.c
+++ b/hw/rdma/rdma_backend.c
@@ -774,7 +774,7 @@ int rdma_backend_init(RdmaBackendDev *backend_dev,
goto out_destroy_comm_channel;
}
- if (backend_dev->backend_gid_idx > port_attr.gid_tbl_len) {
+ if (backend_dev->backend_gid_idx >= port_attr.gid_tbl_len) {
error_setg(errp, "Invalid backend_gid_idx, should be less than %d",
port_attr.gid_tbl_len);
goto out_destroy_comm_channel;
--
2.14.3
next prev parent reply other threads:[~2018-04-30 20:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-30 20:02 [Qemu-devel] [PATCH 0/7] hw/rdma: coverity fixes Marcel Apfelbaum
2018-04-30 20:02 ` [Qemu-devel] [PATCH 1/7] hw/rdma: Fix possible munmap call on a NULL pointer Marcel Apfelbaum
2018-04-30 20:02 ` [Qemu-devel] [PATCH 2/7] hw/rdma: Fix possible usage of " Marcel Apfelbaum
2018-05-01 3:04 ` Philippe Mathieu-Daudé
2018-04-30 20:02 ` [Qemu-devel] [PATCH 3/7] hw/rdma: Delete port's pkey table Marcel Apfelbaum
2018-04-30 20:02 ` [Qemu-devel] [PATCH 4/7] hw/rdma: Fix possible out of bounds access to GID table Marcel Apfelbaum
2018-04-30 20:02 ` [Qemu-devel] [PATCH 5/7] hw/rdma: Fix possible out of bounds access to regs array Marcel Apfelbaum
2018-04-30 20:02 ` [Qemu-devel] [PATCH 6/7] hw/rdma: Delete duplicate definition of MAX_RM_TBL_NAME Marcel Apfelbaum
2018-04-30 20:02 ` Marcel Apfelbaum [this message]
2018-04-30 21:14 ` [Qemu-devel] [PATCH 7/7] hw/rdma: Fix possible out of bounds access to port GID index Eric Blake
2018-05-01 8:58 ` Marcel Apfelbaum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180430200223.4119-8-marcel.apfelbaum@gmail.com \
--to=marcel.apfelbaum@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).