From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org
Subject: [Qemu-devel] [PATCH 0/2] target/arm: Coverity fixups
Date: Tue, 1 May 2018 11:04:53 -0700 [thread overview]
Message-ID: <20180501180455.11214-1-richard.henderson@linaro.org> (raw)
The first patch covers four related false positives. However,
we check the same condition twice and we certainly don't need
to that. Plus the assert might just help documentation-wise.
The second patch covers dead code. I believe that Coverity is
right and that there are no paths that have !is_q at this point.
Add the assert to check that is true.
The RISU tests that I ran over these insns came out clean.
r~
Richard Henderson (2):
target/arm: Tidy conditions in handle_vec_simd_shri
target/arm: Tidy condition in disas_simd_two_reg_misc
target/arm/translate-a64.c | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
--
2.14.3
next reply other threads:[~2018-05-01 18:05 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 18:04 Richard Henderson [this message]
2018-05-01 18:04 ` [Qemu-devel] [PATCH 1/2] target/arm: Tidy conditions in handle_vec_simd_shri Richard Henderson
2018-05-02 9:46 ` [Qemu-devel] [Qemu-arm] " Alex Bennée
2018-05-01 18:04 ` [Qemu-devel] [PATCH 2/2] target/arm: Tidy condition in disas_simd_two_reg_misc Richard Henderson
2018-05-02 9:47 ` [Qemu-devel] [Qemu-arm] " Alex Bennée
2018-05-03 15:05 ` [Qemu-devel] [PATCH 0/2] target/arm: Coverity fixups Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180501180455.11214-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).