[Qemu-devel] [PATCH 0/1] target/arm: Correct MPUIR PL setting in register_cp_regs_for_features()

[Qemu-devel] [PATCH 0/1] target/arm: Correct MPUIR PL setting in register_cp_regs_for_features()

[Mathew Maidment]

Hey there! This is my first time sending a patch via a mailing list so
hopefully I didn't bungle this up *too* badly.

Mat

Mathew Maidment (1):
  target/arm: Correct MPUIR privilege level in
    register_cp_regs_for_features()

 target/arm/helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

-- 
2.15.1

[Qemu-devel] [PATCH 1/1] target/arm: Correct MPUIR privilege level in register_cp_regs_for_features() conditional case

[Mathew Maidment]

The duplication of id_tlbtr_reginfo was unintentionally added within
3281af8114c6b8ead02f08b58e3c36895c1ea047 which should have been id_mpuir_reginfo.

Signed-off-by: Mathew Maidment <mathew1800@gmail.com>
---
 target/arm/helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/target/arm/helper.c b/target/arm/helper.c
index 52a88e0297..0fef5d4d06 100644
--- a/target/arm/helper.c
+++ b/target/arm/helper.c
@@ -5347,7 +5347,7 @@ void register_cp_regs_for_features(ARMCPU *cpu)
             for (r = id_cp_reginfo; r->type != ARM_CP_SENTINEL; r++) {
                 r->access = PL1_RW;
             }
-            id_tlbtr_reginfo.access = PL1_RW;
+            id_mpuir_reginfo.access = PL1_RW;
             id_tlbtr_reginfo.access = PL1_RW;
         }
         if (arm_feature(env, ARM_FEATURE_V8)) {
-- 
2.15.1 (Apple Git-101)

Re: [Qemu-devel] [PATCH 0/1] target/arm: Correct MPUIR PL setting in register_cp_regs_for_features()

[Peter Maydell]

On 1 May 2018 at 19:49, Mathew Maidment <mathew1800@gmail.com> wrote:
> Hey there! This is my first time sending a patch via a mailing list so
> hopefully I didn't bungle this up *too* badly.
>
> Mat
>
> Mathew Maidment (1):
>   target/arm: Correct MPUIR privilege level in
>     register_cp_regs_for_features()
>
>  target/arm/helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Hi -- thanks for this patch! It all looks good and I have added
it to my target-arm.next queue. (I made a minor edit to
the commit message to note that this bug only affected
OMAP and StrongARM cores.)

-- PMM