From: Fam Zheng <famz@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: "Samuel Thibault" <samuel.thibault@ens-lyon.org>,
"Jan Kiszka" <jan.kiszka@siemens.com>,
"Jason Wang" <jasowang@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
qemu-devel@nongnu.org, "Alex Bennée" <alex.bennee@linaro.org>,
"Markus Armbruster" <armbru@redhat.com>
Subject: Re: [Qemu-devel] [PATCH for-2.13 v3 1/2] slirp: Add "query-usernet" QMP command
Date: Wed, 2 May 2018 17:11:28 +0800 [thread overview]
Message-ID: <20180502091128.GB15438@lemon.usersys.redhat.com> (raw)
In-Reply-To: <363615e0-22b3-6fca-c90a-2a6ce205c609@redhat.com>
On Wed, 05/02 09:44, Thomas Huth wrote:
> On 02.05.2018 09:29, Fam Zheng wrote:
> > On Tue, 05/01 22:41, Samuel Thibault wrote:
> >> Hello,
> >>
> >> I'm sorry I didn't find the time to have a look at it before.
> >>
> >> In general it looks good, just a few things:
> >>
> >> Samuel
> >>
> >> Fam Zheng, le ven. 16 mars 2018 14:28:21 +0800, a ecrit:
> >>> + if (!net_hub_id_for_client(&s->nc, &vlan)) {
> >>
> >> That makes me think that IIUC, we shouldn't call them vlan, as mentioned
> >> in the recent vlan->hub renaming patches.
> >>
> >>> +{ 'struct': 'UsernetInfo',
> >>> + 'data': {
> >>> + 'id': 'str',
> >>> + 'vlan': 'int',
> >>
> >> and here as well, I guess.
> >
> > OK, so rename this to hub? (I'm not familiar with the naming issue you pointed
> > out).
>
> Yes, please rename it to "hub". See:
>
> https://lists.gnu.org/archive/html/qemu-devel/2018-04/msg05448.html
OK, thanks. I've posted v4 with it renamed.
Fam
next prev parent reply other threads:[~2018-05-02 9:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-16 6:28 [Qemu-devel] [PATCH for-2.13 v3 0/2] slirp: Add query-usernet QMP command Fam Zheng
2018-03-16 6:28 ` [Qemu-devel] [PATCH for-2.13 v3 1/2] slirp: Add "query-usernet" " Fam Zheng
2018-05-01 20:41 ` Samuel Thibault
2018-05-02 7:29 ` Fam Zheng
2018-05-02 7:44 ` Thomas Huth
2018-05-02 9:11 ` Fam Zheng [this message]
2018-05-02 7:45 ` Samuel Thibault
2018-05-02 8:20 ` Thomas Huth
2018-03-16 6:28 ` [Qemu-devel] [PATCH for-2.13 v3 2/2] tests: Use query-usernet instead of 'info usernet' Fam Zheng
2018-03-20 2:37 ` [Qemu-devel] [PATCH for-2.13 v3 0/2] slirp: Add query-usernet QMP command Jason Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180502091128.GB15438@lemon.usersys.redhat.com \
--to=famz@redhat.com \
--cc=alex.bennee@linaro.org \
--cc=armbru@redhat.com \
--cc=f4bug@amsat.org \
--cc=jan.kiszka@siemens.com \
--cc=jasowang@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=samuel.thibault@ens-lyon.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).