qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: joserz@linux.ibm.com
To: qemu-devel@nongnu.org
Cc: leandro.lupori@gmail.com, qemu-ppc@nongnu.org,
	david@gibson.dropbear.id.au,
	Richard Henderson <richard.henderson@linaro.org>
Subject: Re: [Qemu-devel] [PATCH] Allow PIR read in privileged mode
Date: Thu, 3 May 2018 09:18:47 -0300	[thread overview]
Message-ID: <20180503121847.GA28013@pacoca> (raw)

> According to PowerISA, the PIR register should be readable in privileged mode also, not only in hypervisor privileged mode.

The code makes sense but it doesn't seem created by git format-patch. If
so, could you please follow the instructions from
https://wiki.qemu.org/Contribute/SubmitAPatch and resend it? (note you
need to cc the maintainers)

In the next version you can include my review.

Reviewed-by: Jose Ricardo Ziviani <joserz@linux.ibm.com>

Thanks

             reply	other threads:[~2018-05-03 12:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-03 12:18 joserz [this message]
  -- strict thread matches above, loose matches on Subject: below --
2018-05-07 13:48 [Qemu-devel] [PATCH] Allow PIR read in privileged mode luporl
2018-04-26 16:14 Leandro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180503121847.GA28013@pacoca \
    --to=joserz@linux.ibm.com \
    --cc=CAC7XEcLTBGZ815iMa_Uwz7+FiTm_8dVAT+banx4hcEbY=ui8uQ@mail.gmail.com \
    --cc=david@gibson.dropbear.id.au \
    --cc=leandro.lupori@gmail.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-ppc@nongnu.org \
    --cc=richard.henderson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).