From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:58480) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEFdY-0002nc-Pk for qemu-devel@nongnu.org; Thu, 03 May 2018 10:55:13 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEFdV-0001Mo-NB for qemu-devel@nongnu.org; Thu, 03 May 2018 10:55:12 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:57734 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fEFdV-0001Mc-H0 for qemu-devel@nongnu.org; Thu, 03 May 2018 10:55:09 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F25394270961 for ; Thu, 3 May 2018 14:55:08 +0000 (UTC) Date: Thu, 3 May 2018 15:55:02 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20180503145501.GH2660@work-vm> References: <20180425112723.1111-1-quintela@redhat.com> <20180425112723.1111-19-quintela@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180425112723.1111-19-quintela@redhat.com> Subject: Re: [Qemu-devel] [PATCH v12 18/21] migration: Start sending messages List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: qemu-devel@nongnu.org, lvivier@redhat.com, peterx@redhat.com * Juan Quintela (quintela@redhat.com) wrote: > Signed-off-by: Juan Quintela > --- > migration/ram.c | 30 ++++++++++++++++++++++++------ > 1 file changed, 24 insertions(+), 6 deletions(-) > > diff --git a/migration/ram.c b/migration/ram.c > index 862ec53d32..9adbaa81f9 100644 > --- a/migration/ram.c > +++ b/migration/ram.c > @@ -625,9 +625,6 @@ static int multifd_recv_unfill_packet(MultiFDRecvParams *p, Error **errp) > RAMBlock *block; > int i; > > - /* ToDo: We can't use it until we haven't received a message */ > - return 0; > - > be32_to_cpus(&packet->magic); > if (packet->magic != MULTIFD_MAGIC) { > error_setg(errp, "multifd: received packet " > @@ -851,6 +848,7 @@ static void *multifd_send_thread(void *opaque) > { > MultiFDSendParams *p = opaque; > Error *local_err = NULL; > + int ret; > > trace_multifd_send_thread_start(p->id); > > @@ -878,10 +876,18 @@ static void *multifd_send_thread(void *opaque) > > trace_multifd_send(p->id, seq, used, flags); > > - /* ToDo: send packet here */ > + ret = qio_channel_write_all(p->c, (void *)p->packet, > + p->packet_len, &local_err); > + if (ret != 0) { > + break; > + } > + > + ret = qio_channel_writev_all(p->c, p->pages->iov, used, &local_err); > + if (ret != 0) { > + break; > + } > > qemu_mutex_lock(&p->mutex); > - p->flags = 0; What's this change? Other than that looks OK. Dave > p->pending_job--; > qemu_mutex_unlock(&p->mutex); > > @@ -1091,7 +1097,14 @@ static void *multifd_recv_thread(void *opaque) > uint32_t flags; > qemu_mutex_unlock(&p->mutex); > > - /* ToDo: recv packet here */ > + ret = qio_channel_read_all_eof(p->c, (void *)p->packet, > + p->packet_len, &local_err); > + if (ret == 0) { /* EOF */ > + break; > + } > + if (ret == -1) { /* Error */ > + break; > + } > > qemu_mutex_lock(&p->mutex); > ret = multifd_recv_unfill_packet(p, &local_err); > @@ -1108,6 +1121,11 @@ static void *multifd_recv_thread(void *opaque) > p->num_pages += used; > qemu_mutex_unlock(&p->mutex); > > + ret = qio_channel_readv_all(p->c, p->pages->iov, used, &local_err); > + if (ret != 0) { > + break; > + } > + > if (flags & MULTIFD_FLAG_SYNC) { > qemu_sem_post(&multifd_recv_state->sem_sync); > qemu_sem_wait(&p->sem_sync); > -- > 2.17.0 > -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK