From: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
To: qemu-devel@nongnu.org
Cc: marcel.apfelbaum@gmail.com, yuval.shaia@oracle.com,
peter.maydell@linaro.org, f4bug@amsat.org
Subject: [Qemu-devel] [PULL 3/8] hw/rdma: Delete port's pkey table
Date: Thu, 3 May 2018 21:21:20 +0300 [thread overview]
Message-ID: <20180503182125.20310-4-marcel.apfelbaum@gmail.com> (raw)
In-Reply-To: <20180503182125.20310-1-marcel.apfelbaum@gmail.com>
From: Yuval Shaia <yuval.shaia@oracle.com>
Support for PKEY is not yet implemented. Removing the unneeded table
until a support will be added.
Signed-off-by: Yuval Shaia <yuval.shaia@oracle.com>
Reviewed-by: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Message-Id: <20180430200223.4119-4-marcel.apfelbaum@gmail.com>
---
hw/rdma/rdma_rm_defs.h | 3 +--
hw/rdma/vmw/pvrdma_main.c | 15 ---------------
2 files changed, 1 insertion(+), 17 deletions(-)
diff --git a/hw/rdma/rdma_rm_defs.h b/hw/rdma/rdma_rm_defs.h
index fc646da61f..45503f14e0 100644
--- a/hw/rdma/rdma_rm_defs.h
+++ b/hw/rdma/rdma_rm_defs.h
@@ -21,7 +21,7 @@
#define MAX_PORTS 1
#define MAX_PORT_GIDS 1
#define MAX_PORT_PKEYS 1
-#define MAX_PKEYS 1
+#define MAX_PKEYS MAX_PORT_PKEYS
#define MAX_GIDS 2048
#define MAX_UCS 512
#define MAX_MR_SIZE (1UL << 27)
@@ -87,7 +87,6 @@ typedef struct RdmaRmQP {
typedef struct RdmaRmPort {
union ibv_gid gid_tbl[MAX_PORT_GIDS];
enum ibv_port_state state;
- int *pkey_tbl; /* TODO: Not yet supported */
} RdmaRmPort;
typedef struct RdmaDeviceResources {
diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
index c552248c90..994220b58e 100644
--- a/hw/rdma/vmw/pvrdma_main.c
+++ b/hw/rdma/vmw/pvrdma_main.c
@@ -275,15 +275,6 @@ static void init_dsr_dev_caps(PVRDMADev *dev)
pr_dbg("Initialized\n");
}
-static void free_ports(PVRDMADev *dev)
-{
- int i;
-
- for (i = 0; i < MAX_PORTS; i++) {
- g_free(dev->rdma_dev_res.ports[i].gid_tbl);
- }
-}
-
static void init_ports(PVRDMADev *dev, Error **errp)
{
int i;
@@ -292,10 +283,6 @@ static void init_ports(PVRDMADev *dev, Error **errp)
for (i = 0; i < MAX_PORTS; i++) {
dev->rdma_dev_res.ports[i].state = IBV_PORT_DOWN;
-
- dev->rdma_dev_res.ports[i].pkey_tbl =
- g_malloc0(sizeof(*dev->rdma_dev_res.ports[i].pkey_tbl) *
- MAX_PORT_PKEYS);
}
}
@@ -622,8 +609,6 @@ static void pvrdma_exit(PCIDevice *pdev)
pvrdma_qp_ops_fini();
- free_ports(dev);
-
rdma_rm_fini(&dev->rdma_dev_res);
rdma_backend_fini(&dev->backend_dev);
--
2.14.3
next prev parent reply other threads:[~2018-05-03 18:20 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 18:21 [Qemu-devel] [PULL 0/8] RDMA queue Marcel Apfelbaum
2018-05-03 18:21 ` [Qemu-devel] [PULL 1/8] hw/rdma: Fix possible munmap call on a NULL pointer Marcel Apfelbaum
2018-05-03 18:21 ` [Qemu-devel] [PULL 2/8] hw/rdma: Fix possible usage of " Marcel Apfelbaum
2018-05-03 18:21 ` Marcel Apfelbaum [this message]
2018-05-03 18:21 ` [Qemu-devel] [PULL 4/8] hw/rdma: Fix possible out of bounds access to GID table Marcel Apfelbaum
2018-05-03 18:21 ` [Qemu-devel] [PULL 5/8] hw/rdma: Fix possible out of bounds access to regs array Marcel Apfelbaum
2018-05-03 18:21 ` [Qemu-devel] [PULL 6/8] hw/rdma: Delete duplicate definition of MAX_RM_TBL_NAME Marcel Apfelbaum
2018-05-03 18:21 ` [Qemu-devel] [PULL 7/8] hw/rdma: Fix possible out of bounds access to port GID index Marcel Apfelbaum
2018-05-03 18:21 ` [Qemu-devel] [PULL 8/8] MAINTAINERS: update Marcel Apfelbaum email Marcel Apfelbaum
2018-05-04 8:24 ` [Qemu-devel] [PULL 0/8] RDMA queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503182125.20310-4-marcel.apfelbaum@gmail.com \
--to=marcel.apfelbaum@gmail.com \
--cc=f4bug@amsat.org \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=yuval.shaia@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).