From: Jeff Cody <jcody@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, Kevin Wolf <kwolf@redhat.com>,
qemu-block@nongnu.org, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 0/2] qemu-iotests: post-QEMU 2.12 fixes for 185
Date: Fri, 4 May 2018 13:46:19 -0400 [thread overview]
Message-ID: <20180504174619.GA3107@localhost.localdomain> (raw)
In-Reply-To: <20180504155014.10311-1-stefanha@redhat.com>
On Fri, May 04, 2018 at 04:50:12PM +0100, Stefan Hajnoczi wrote:
> The 185 qemu-iotests test case was in a bad state for the QEMU 2.12 release.
> We fudged the expected test output to make it pass, except for
> non-deterministic behavior.
>
> These patches get us back to pre-QEMU 2.12. Notably the offsets reported in
> block job events now correspond to smaller buffer sizes because the job doesn't
> iterate during drain.
>
> It's worth mentioning that the test case is still non-deterministic. For more
> on that, see the first patch.
>
> Stefan Hajnoczi (2):
> qemu-iotests: reduce chance of races in 185
> blockjob: do not cancel timer in resume
>
> blockjob.c | 22 +++++++++++++++-------
> tests/qemu-iotests/185 | 12 ++++++++++++
> tests/qemu-iotests/185.out | 10 +++++-----
> 3 files changed, 32 insertions(+), 12 deletions(-)
>
> --
> 2.14.3
>
This series has a minor collision with my block branch in the output; would
you like me to just merge together the appropriate 185.out when applying?
-Jeff
next prev parent reply other threads:[~2018-05-04 17:46 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 15:50 [Qemu-devel] [PATCH 0/2] qemu-iotests: post-QEMU 2.12 fixes for 185 Stefan Hajnoczi
2018-05-04 15:50 ` [Qemu-devel] [PATCH 1/2] qemu-iotests: reduce chance of races in 185 Stefan Hajnoczi
2018-05-04 17:43 ` Vladimir Sementsov-Ogievskiy
2018-05-08 13:06 ` [Qemu-devel] [Qemu-block] " Stefan Hajnoczi
2018-05-04 15:50 ` [Qemu-devel] [PATCH 2/2] blockjob: do not cancel timer in resume Stefan Hajnoczi
2018-05-04 15:55 ` [Qemu-devel] [Qemu-block] [PATCH 0/2] qemu-iotests: post-QEMU 2.12 fixes for 185 Stefan Hajnoczi
2018-05-04 17:46 ` Jeff Cody [this message]
2018-05-08 13:07 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180504174619.GA3107@localhost.localdomain \
--to=jcody@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).