From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:33629) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fEems-0002aY-KI for qemu-devel@nongnu.org; Fri, 04 May 2018 13:46:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fEemr-0006c4-NL for qemu-devel@nongnu.org; Fri, 04 May 2018 13:46:30 -0400 Date: Fri, 4 May 2018 13:46:19 -0400 From: Jeff Cody Message-ID: <20180504174619.GA3107@localhost.localdomain> References: <20180504155014.10311-1-stefanha@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180504155014.10311-1-stefanha@redhat.com> Subject: Re: [Qemu-devel] [PATCH 0/2] qemu-iotests: post-QEMU 2.12 fixes for 185 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Stefan Hajnoczi Cc: qemu-devel@nongnu.org, Kevin Wolf , qemu-block@nongnu.org, Max Reitz On Fri, May 04, 2018 at 04:50:12PM +0100, Stefan Hajnoczi wrote: > The 185 qemu-iotests test case was in a bad state for the QEMU 2.12 release. > We fudged the expected test output to make it pass, except for > non-deterministic behavior. > > These patches get us back to pre-QEMU 2.12. Notably the offsets reported in > block job events now correspond to smaller buffer sizes because the job doesn't > iterate during drain. > > It's worth mentioning that the test case is still non-deterministic. For more > on that, see the first patch. > > Stefan Hajnoczi (2): > qemu-iotests: reduce chance of races in 185 > blockjob: do not cancel timer in resume > > blockjob.c | 22 +++++++++++++++------- > tests/qemu-iotests/185 | 12 ++++++++++++ > tests/qemu-iotests/185.out | 10 +++++----- > 3 files changed, 32 insertions(+), 12 deletions(-) > > -- > 2.14.3 > This series has a minor collision with my block branch in the output; would you like me to just merge together the appropriate 185.out when applying? -Jeff