qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Stefan Hajnoczi <stefanha@gmail.com>
To: Andrew Wood <andrewjameswood@ymail.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] Unix signal to send ACPI-shutdown to Guest
Date: Tue, 8 May 2018 11:11:21 +0100	[thread overview]
Message-ID: <20180508101121.GD19710@stefanha-x1.localdomain> (raw)
In-Reply-To: <ba020090-1877-6b9a-891d-dbfbabf25c71@ymail.com>

[-- Attachment #1: Type: text/plain, Size: 1266 bytes --]

On Sat, Apr 28, 2018 at 11:59:41PM +0100, Andrew Wood via Qemu-devel wrote:
> Ive been looking into the possibility of using a unix signal to send an acpi
> shutdown request to a VM, and came across a posting on this l in March 1.
> See https://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg04169.html
> 
> 
> To summarise to refresh memories  there was a patch proposed using SIGINT
> followed by discussion as to why SIGINT wasnt ideal because it would cause
> regressions for anyone relying on the existing handling of SIGINT, and
> various other signals were considered including HUP & USR1 & USR2 all of
> which are already used for something else.
> 
> Is SIGPWR a suitable candidate, I have made a patch to use SIGPWR but as Im
> new to QEMUs internals Im not sure if there are any circumstances in which
> an alternative handler is registered for SIGPWR which might conflict?

A quick grep of the Linux kernel code suggests that SIGPWR is very
rarely raised by the kernel.  It's only sent to init on s390 and Silicon
Graphics SN systems.  QEMU could use the signal on Linux without risk of
collision.

It's worth sending a patch.  Here are the patch submission guidelines:
https://wiki.qemu.org/Contribute/SubmitAPatch

Stefan

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]

      reply	other threads:[~2018-05-08 10:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-28 22:59 [Qemu-devel] Unix signal to send ACPI-shutdown to Guest Andrew Wood
2018-05-08 10:11 ` Stefan Hajnoczi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180508101121.GD19710@stefanha-x1.localdomain \
    --to=stefanha@gmail.com \
    --cc=andrewjameswood@ymail.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).