From: Stefan Hajnoczi <stefanha@gmail.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, "Markus Armbruster" <armbru@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v4 1/4] monitor: rename out_lock to mon_lock
Date: Tue, 8 May 2018 11:26:21 +0100 [thread overview]
Message-ID: <20180508102621.GF19710@stefanha-x1.localdomain> (raw)
In-Reply-To: <20180502100422.8688-2-peterx@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 642 bytes --]
On Wed, May 02, 2018 at 06:04:19PM +0800, Peter Xu wrote:
> The out_lock was only protecting a few Monitor fields. In the future
> the monitor code will start to run in multiple threads. We turn it into
> a bigger lock to protect not only the out buffer but also all the rest.
> For now we share the lock. We can split the lock when needed.
>
> Since at it, arrange the Monitor struct a bit.
>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
> monitor.c | 53 +++++++++++++++++++++++++++++------------------------
> 1 file changed, 29 insertions(+), 24 deletions(-)
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2018-05-08 10:26 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-02 10:04 [Qemu-devel] [PATCH v4 0/4] monitor: let Monitor be thread safe Peter Xu
2018-05-02 10:04 ` [Qemu-devel] [PATCH v4 1/4] monitor: rename out_lock to mon_lock Peter Xu
2018-05-08 10:26 ` Stefan Hajnoczi [this message]
2018-05-02 10:04 ` [Qemu-devel] [PATCH v4 2/4] monitor: protect mon->fds with mon_lock Peter Xu
2018-05-02 11:15 ` Dr. David Alan Gilbert
2018-05-02 11:28 ` Peter Xu
2018-05-02 10:04 ` [Qemu-devel] [PATCH v4 3/4] monitor: more comments on lock-free fleids/funcs Peter Xu
2018-05-08 10:23 ` Stefan Hajnoczi
2018-05-08 10:32 ` Peter Xu
2018-05-08 14:09 ` Stefan Hajnoczi
2018-05-02 10:04 ` [Qemu-devel] [PATCH v4 4/4] monitor: add lock to protect mon_fdsets Peter Xu
2018-05-08 10:26 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508102621.GF19710@stefanha-x1.localdomain \
--to=stefanha@gmail.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).