From: Cornelia Huck <cohuck@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>,
Alexander Graf <agraf@suse.de>
Cc: Thomas Huth <thuth@redhat.com>, Halil Pasic <pasic@linux.ibm.com>,
qemu-s390x@nongnu.org, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] s390x/css: disabled subchannels cannot be status pending
Date: Tue, 8 May 2018 11:55:21 +0200 [thread overview]
Message-ID: <20180508115521.0ef49d72.cohuck@redhat.com> (raw)
In-Reply-To: <20180504131605.22816-1-cohuck@redhat.com>
On Fri, 4 May 2018 15:16:05 +0200
Cornelia Huck <cohuck@redhat.com> wrote:
> The 3270 code will try to post an attention interrupt when the
> 3270 emulator (e.g. x3270) attaches. If the guest has not yet
> enabled the subchannel for the 3270 device, we will give it a
> spurious status during msch when it does so later.
>
> To fix this, just don't do anything in css_conditional_io_interrupt()
> if the subchannel is not enabled. The 3270 code will work fine with
> that, and the other user of this function (virtio-ccw) never
> attempts to post an interrupt for a disabled device to begin with.
>
> Reported-by: Thomas Huth <thuth@redhat.com>
> Signed-off-by: Cornelia Huck <cohuck@redhat.com>
> ---
> hw/s390x/css.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
Queued to s390-next (with commit message tweaked and cc:stable added).
prev parent reply other threads:[~2018-05-08 9:55 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 13:16 [Qemu-devel] [PATCH] s390x/css: disabled subchannels cannot be status pending Cornelia Huck
2018-05-04 13:39 ` Thomas Huth
2018-05-04 13:44 ` [Qemu-devel] [qemu-s390x] " Christian Borntraeger
2018-05-04 15:02 ` [Qemu-devel] " Halil Pasic
2018-05-07 10:12 ` Cornelia Huck
2018-05-07 11:08 ` Halil Pasic
2018-05-07 8:41 ` [Qemu-devel] [qemu-s390x] " David Hildenbrand
2018-05-08 9:55 ` Cornelia Huck [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508115521.0ef49d72.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=agraf@suse.de \
--cc=borntraeger@de.ibm.com \
--cc=pasic@linux.ibm.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).