From: Kevin Wolf <kwolf@redhat.com>
To: Alberto Garcia <berto@igalia.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
Markus Armbruster <armbru@redhat.com>,
Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] hmp: Allow using a qdev id in block_set_io_throttle
Date: Tue, 8 May 2018 14:06:29 +0200 [thread overview]
Message-ID: <20180508120629.GB4065@localhost.localdomain> (raw)
In-Reply-To: <20180309141107.13964-1-berto@igalia.com>
Am 09.03.2018 um 15:11 hat Alberto Garcia geschrieben:
> The QMP version of this command can take a qdev ID since 7a9877a02635,
> but the HMP version is still using the deprecated block device name so
> there's no way to refer to a block device added like this:
>
> -blockdev node-name=disk0,driver=qcow2,file.driver=file,file.filename=hd.qcow2
> -device virtio-blk-pci,id=virtio-blk-pci0,drive=disk0
>
> This patch works around this problem by using the specified name as a
> qdev ID if the block device name is not found.
>
> Signed-off-by: Alberto Garcia <berto@igalia.com>
Thanks, applied to the block branch.
Kevin
prev parent reply other threads:[~2018-05-08 12:06 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 14:11 [Qemu-devel] [PATCH] hmp: Allow using a qdev id in block_set_io_throttle Alberto Garcia
2018-03-09 14:52 ` Eric Blake
2018-05-08 12:06 ` Kevin Wolf [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508120629.GB4065@localhost.localdomain \
--to=kwolf@redhat.com \
--cc=armbru@redhat.com \
--cc=berto@igalia.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).