From: Jeff Cody <jcody@redhat.com>
To: John Snow <jsnow@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org, qemu-trivial@nongnu.org
Subject: Re: [Qemu-devel] [Qemu-block] [PATCH 1/5] qemu-img-commands.hx: argument ordering fixups
Date: Tue, 8 May 2018 11:33:08 -0400 [thread overview]
Message-ID: <20180508153308.GA6722@localhost.localdomain> (raw)
In-Reply-To: <20180503225648.13153-2-jsnow@redhat.com>
On Thu, May 03, 2018 at 06:56:44PM -0400, John Snow wrote:
> The TEXI and string versions are actually identical, except for markup.
> We can probably automate this... but make the ordering the same until
> then.
>
> Signed-off-by: John Snow <jsnow@redhat.com>
Reviewed-by: Jeff Cody <jcody@redhat.com>
> ---
> qemu-img-cmds.hx | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/qemu-img-cmds.hx b/qemu-img-cmds.hx
> index 2fe31893cf..8bcefcafe9 100644
> --- a/qemu-img-cmds.hx
> +++ b/qemu-img-cmds.hx
> @@ -23,13 +23,13 @@ STEXI
> ETEXI
>
> DEF("check", img_check,
> - "check [-q] [--object objectdef] [--image-opts] [-f fmt] [--output=ofmt] [-r [leaks | all]] [-T src_cache] [-U] filename")
> + "check [--object objectdef] [--image-opts] [-q] [-f fmt] [--output=ofmt] [-r [leaks | all]] [-T src_cache] [-U] filename")
> STEXI
> @item check [--object @var{objectdef}] [--image-opts] [-q] [-f @var{fmt}] [--output=@var{ofmt}] [-r [leaks | all]] [-T @var{src_cache}] [-U] @var{filename}
> ETEXI
>
> DEF("commit", img_commit,
> - "commit [-q] [--object objectdef] [--image-opts] [-f fmt] [-t cache] [-b base] [-d] [-p] filename")
> + "commit [--object objectdef] [--image-opts] [-q] [-f fmt] [-t cache] [-b base] [-d] [-p] filename")
> STEXI
> @item commit [--object @var{objectdef}] [--image-opts] [-q] [-f @var{fmt}] [-t @var{cache}] [-b @var{base}] [-d] [-p] @var{filename}
> ETEXI
> @@ -47,7 +47,7 @@ STEXI
> ETEXI
>
> DEF("create", img_create,
> - "create [-q] [--object objectdef] [-f fmt] [-b backing_file] [-F backing_fmt] [-u] [-o options] filename [size]")
> + "create [--object objectdef] [-q] [-f fmt] [-b backing_file] [-F backing_fmt] [-u] [-o options] filename [size]")
> STEXI
> @item create [--object @var{objectdef}] [-q] [-f @var{fmt}] [-b @var{backing_file}] [-F @var{backing_fmt}] [-u] [-o @var{options}] @var{filename} [@var{size}]
> ETEXI
> --
> 2.14.3
>
>
next prev parent reply other threads:[~2018-05-08 15:33 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-03 22:56 [Qemu-devel] [PATCH 0/5] qemu-img: make subcommand usage docstrings consistent John Snow
2018-05-03 22:56 ` [Qemu-devel] [PATCH 1/5] qemu-img-commands.hx: argument ordering fixups John Snow
2018-05-08 15:33 ` Jeff Cody [this message]
2018-05-03 22:56 ` [Qemu-devel] [PATCH 2/5] qemu-img.texi: fix command ordering John Snow
2018-05-08 15:33 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-03 22:56 ` [Qemu-devel] [PATCH 3/5] qemu-img: remove references to GEN_DOCS John Snow
2018-05-08 15:45 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-03 22:56 ` [Qemu-devel] [PATCH 4/5] qemu-img: Make documentation between .texi and .hx consistent John Snow
2018-05-08 15:45 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-03 22:56 ` [Qemu-devel] [PATCH 5/5] qemu-img-cmds.hx: add passive-aggressive note John Snow
2018-05-08 15:49 ` [Qemu-devel] [Qemu-block] " Jeff Cody
2018-05-04 1:03 ` [Qemu-devel] [PATCH 0/5] qemu-img: make subcommand usage docstrings consistent John Snow
2018-05-09 18:07 ` [Qemu-devel] [Qemu-block] " Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508153308.GA6722@localhost.localdomain \
--to=jcody@redhat.com \
--cc=jsnow@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).