From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>,
Markus Armbruster <armbru@redhat.com>,
Thomas Huth <thuth@redhat.com>, Olaf Hering <olaf@aepfle.de>,
Stefan Hajnoczi <stefanha@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>,
Eric Blake <eblake@redhat.com>,
Stefan Berger <stefanb@linux.vnet.ibm.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] glib: enforce the minimum required version and warn about old APIs
Date: Tue, 8 May 2018 17:14:01 +0100 [thread overview]
Message-ID: <20180508161401.GI5967@redhat.com> (raw)
In-Reply-To: <ea7bffe9-5219-43a9-a250-b60b67b69b55@redhat.com>
On Tue, May 08, 2018 at 06:02:55PM +0200, Paolo Bonzini wrote:
> On 08/05/2018 17:19, Daniel P. Berrangé wrote:
> > Ok, that change looks fine with me assuming it passes your build tests.
> > In fact that is what I had done in an earlier version.
> >
> > Regards,
> > Daniel
>
> Actually there is a use of g_strv_contains in tests/test-qga.c. It is
> guarded by GLIB_CHECK_VERSION(2, 44, 0) but the right fix should be to
> include the compatibility function instead.
>
> For now I am dropping this patch.
Ok, I'll have a look at that, and re-post an updated patch later. There
are a few other uses of GLIB_CHECK_VERSION to be investigated too I see.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2018-05-08 16:14 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-04 16:00 [Qemu-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42 Daniel P. Berrangé
2018-05-04 16:00 ` [Qemu-devel] [PATCH 1/3] qemu-doc: provide details of supported build platforms Daniel P. Berrangé
2018-05-04 16:00 ` [Qemu-devel] [PATCH 2/3] glib: bump min required glib library version to 2.42 Daniel P. Berrangé
2018-05-04 20:02 ` Eric Blake
2018-05-04 16:00 ` [Qemu-devel] [PATCH 3/3] glib: enforce the minimum required version and warn about old APIs Daniel P. Berrangé
2018-05-08 15:17 ` Paolo Bonzini
2018-05-08 15:19 ` Daniel P. Berrangé
2018-05-08 16:02 ` Paolo Bonzini
2018-05-08 16:14 ` Daniel P. Berrangé [this message]
2018-05-04 16:35 ` [Qemu-devel] [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42 no-reply
2018-05-04 16:36 ` no-reply
2018-05-04 19:40 ` Olaf Hering
2018-05-04 20:57 ` Daniel P. Berrangé
2018-05-04 21:00 ` Daniel P. Berrangé
2018-05-08 14:50 ` [Qemu-devel] [Xen-devel] " George Dunlap
2018-05-08 15:05 ` Paolo Bonzini
2018-05-08 15:10 ` Daniel P. Berrangé
2018-05-08 15:47 ` George Dunlap
2018-05-04 22:05 ` [Qemu-devel] " Paolo Bonzini
2018-05-08 10:42 ` Daniel P. Berrangé
2018-05-08 11:41 ` Paolo Bonzini
2018-05-11 22:48 ` [Qemu-devel] Requiring Python 2.7+ (was Re: [PATCH 0/3] Document intent for supported build platforms and bump min glib to 2.42) Eduardo Habkost
2018-05-14 9:33 ` Daniel P. Berrangé
2018-05-14 9:36 ` Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180508161401.GI5967@redhat.com \
--to=berrange@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=olaf@aepfle.de \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).