From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:39827) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fG68D-0000BC-Od for qemu-devel@nongnu.org; Tue, 08 May 2018 13:10:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fG68A-00055C-G4 for qemu-devel@nongnu.org; Tue, 08 May 2018 13:10:29 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:42012 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fG68A-00054v-AW for qemu-devel@nongnu.org; Tue, 08 May 2018 13:10:26 -0400 Date: Tue, 8 May 2018 18:10:22 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20180508171021.GR2500@work-vm> References: <1525701137-9384-1-git-send-email-lidongchen@tencent.com> <87muxa6pmd.fsf@secure.laptop> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <87muxa6pmd.fsf@secure.laptop> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH 1/2] migration: implement io_set_aio_fd_handler function for RDMA QIOChannel List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Juan Quintela Cc: Lidong Chen , berrange@redhat.com, qemu-devel@nongnu.org, galsha@mellanox.com, aviadye@mellanox.com, adido@mellanox.com, Lidong Chen * Juan Quintela (quintela@redhat.com) wrote: > Lidong Chen wrote: > > if qio_channel_rdma_readv return QIO_CHANNEL_ERR_BLOCK, the destinati= on qemu > > crash. > > > > The backtrace is: > > (gdb) bt > > #0 0x0000000000000000 in ?? () > > #1 0x00000000008db50e in qio_channel_set_aio_fd_handler (ioc=3D0= x38111e0, ctx=3D0x3726080, > > io_read=3D0x8db841 , io_write=3D0x0= , opaque=3D0x38111e0) at io/channel.c: > > #2 0x00000000008db952 in qio_channel_set_aio_fd_handlers (ioc=3D= 0x38111e0) at io/channel.c:438 > > #3 0x00000000008dbab4 in qio_channel_yield (ioc=3D0x38111e0, con= dition=3DG_IO_IN) at io/channel.c:47 > > #4 0x00000000007a870b in channel_get_buffer (opaque=3D0x38111e0,= buf=3D0x440c038 "", pos=3D0, size=3D327 > > at migration/qemu-file-channel.c:83 > > #5 0x00000000007a70f6 in qemu_fill_buffer (f=3D0x440c000) at mig= ration/qemu-file.c:299 > > #6 0x00000000007a79d0 in qemu_peek_byte (f=3D0x440c000, offset=3D= 0) at migration/qemu-file.c:562 > > #7 0x00000000007a7a22 in qemu_get_byte (f=3D0x440c000) at migrat= ion/qemu-file.c:575 > > #8 0x00000000007a7c78 in qemu_get_be32 (f=3D0x440c000) at migrat= ion/qemu-file.c:655 > > #9 0x00000000007a0508 in qemu_loadvm_state (f=3D0x440c000) at mi= gration/savevm.c:2126 > > #10 0x0000000000794141 in process_incoming_migration_co (opaque=3D= 0x0) at migration/migration.c:366 > > #11 0x000000000095c598 in coroutine_trampoline (i0=3D84033984, i1= =3D0) at util/coroutine-ucontext.c:1 > > #12 0x00007f9c0db56d40 in ?? () from /lib64/libc.so.6 > > #13 0x00007f96fe858760 in ?? () > > #14 0x0000000000000000 in ?? () > > > > RDMA QIOChannel not implement io_set_aio_fd_handler. so > > qio_channel_set_aio_fd_handler will access NULL pointer. > > > > Signed-off-by: Lidong Chen > > --- >=20 >=20 > Hi >=20 > could you resend, it don't compile for me :-( This really sits after the other set of rdma changes. I doubt this path is reachable without the previous set. Dave >=20 > /mnt/kvm/qemu/cleanup/migration/rdma.c: In function =E2=80=98qio_channe= l_rdma_set_aio_fd_handler=E2=80=99: > /mnt/kvm/qemu/cleanup/migration/rdma.c:2877:39: error: =E2=80=98QIOChan= nelRDMA=E2=80=99 {aka =E2=80=98struct QIOChannelRDMA=E2=80=99} has no mem= ber named =E2=80=98rdmain=E2=80=99; did you mean =E2=80=98rdma=E2=80=99? > aio_set_fd_handler(ctx, rioc->rdmain->comp_channel->fd, > ^~~~~~ > rdma > /mnt/kvm/qemu/cleanup/migration/rdma.c:2880:39: error: =E2=80=98QIOChan= nelRDMA=E2=80=99 {aka =E2=80=98struct QIOChannelRDMA=E2=80=99} has no mem= ber named =E2=80=98rdmaout=E2=80=99; did you mean =E2=80=98rdma=E2=80=99? > aio_set_fd_handler(ctx, rioc->rdmaout->comp_channel->fd, > ^~~~~~~ > rdma > make: *** [/mnt/kvm/qemu/cleanup/rules.mak:66: migration/rdma.o] Error = 1 > CC migration/block.o > CC ui/vnc.o >=20 > It seems like >=20 > > diff --git a/migration/rdma.c b/migration/rdma.c > > index 92e4d30..dfa4f77 100644 > > --- a/migration/rdma.c > > +++ b/migration/rdma.c > > @@ -2963,6 +2963,21 @@ static GSource *qio_channel_rdma_create_watch(= QIOChannel *ioc, > > return source; > > } > > =20 > > +static void qio_channel_rdma_set_aio_fd_handler(QIOChannel *ioc, > > + AioContext *ctx, > > + IOHandler *io_read= , > > + IOHandler *io_writ= e, > > + void *opaque) > > +{ > > + QIOChannelRDMA *rioc =3D QIO_CHANNEL_RDMA(ioc); > > + if (io_read) { > > + aio_set_fd_handler(ctx, rioc->rdmain->comp_channel->fd, >=20 > this should be rioc->rdam->comp_channel >=20 > > + false, io_read, io_write, NULL, opaque); > > + } else { > > + aio_set_fd_handler(ctx, rioc->rdmaout->comp_channel->fd, >=20 > and this rioc-rdma->comp_channel >=20 > But will preffer if you confirm. >=20 > Thanks. -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK