* [Qemu-devel] [PATCH] m68k: fix floatx80_mod() (Coverity CID1390568)
@ 2018-05-08 20:39 Laurent Vivier
2018-05-09 5:04 ` Thomas Huth
0 siblings, 1 reply; 2+ messages in thread
From: Laurent Vivier @ 2018-05-08 20:39 UTC (permalink / raw)
To: qemu-devel; +Cc: Peter Maydell, Laurent Vivier
Update the variable checked by the loop condition (expDiff).
Backport the update from Previous.
Fixes: 591596b77a ("target/m68k: add fmod/frem")
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
---
target/m68k/softfloat.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/target/m68k/softfloat.c b/target/m68k/softfloat.c
index e41b07d042..d093997219 100644
--- a/target/m68k/softfloat.c
+++ b/target/m68k/softfloat.c
@@ -103,6 +103,7 @@ floatx80 floatx80_mod(floatx80 a, floatx80 b, float_status *status)
mul64To128(bSig, qTemp, &term0, &term1);
sub128(aSig0, aSig1, term0, term1, &aSig0, &aSig1);
shortShift128Left(aSig0, aSig1, 62, &aSig0, &aSig1);
+ expDiff -= 62;
}
expDiff += 64;
if (0 < expDiff) {
--
2.14.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] m68k: fix floatx80_mod() (Coverity CID1390568)
2018-05-08 20:39 [Qemu-devel] [PATCH] m68k: fix floatx80_mod() (Coverity CID1390568) Laurent Vivier
@ 2018-05-09 5:04 ` Thomas Huth
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Huth @ 2018-05-09 5:04 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: Peter Maydell
On 08.05.2018 22:39, Laurent Vivier wrote:
> Update the variable checked by the loop condition (expDiff).
> Backport the update from Previous.
>
> Fixes: 591596b77a ("target/m68k: add fmod/frem")
> Signed-off-by: Laurent Vivier <laurent@vivier.eu>
> ---
> target/m68k/softfloat.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/target/m68k/softfloat.c b/target/m68k/softfloat.c
> index e41b07d042..d093997219 100644
> --- a/target/m68k/softfloat.c
> +++ b/target/m68k/softfloat.c
> @@ -103,6 +103,7 @@ floatx80 floatx80_mod(floatx80 a, floatx80 b, float_status *status)
> mul64To128(bSig, qTemp, &term0, &term1);
> sub128(aSig0, aSig1, term0, term1, &aSig0, &aSig1);
> shortShift128Left(aSig0, aSig1, 62, &aSig0, &aSig1);
> + expDiff -= 62;
> }
> expDiff += 64;
> if (0 < expDiff) {
Reviewed-by: Thomas Huth <huth@tuxfamily.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-09 5:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-08 20:39 [Qemu-devel] [PATCH] m68k: fix floatx80_mod() (Coverity CID1390568) Laurent Vivier
2018-05-09 5:04 ` Thomas Huth
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).