From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34870) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGGYE-00073e-BE for qemu-devel@nongnu.org; Wed, 09 May 2018 00:18:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGGYA-0002sJ-BZ for qemu-devel@nongnu.org; Wed, 09 May 2018 00:18:02 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49838 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fGGYA-0002s9-72 for qemu-devel@nongnu.org; Wed, 09 May 2018 00:17:58 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D6CFC7CBBA for ; Wed, 9 May 2018 04:17:57 +0000 (UTC) From: Peter Xu Date: Wed, 9 May 2018 12:17:33 +0800 Message-Id: <20180509041734.14135-4-peterx@redhat.com> In-Reply-To: <20180509041734.14135-1-peterx@redhat.com> References: <20180509041734.14135-1-peterx@redhat.com> Subject: [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Eric Blake , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Markus Armbruster , Stefan Hajnoczi , "Dr . David Alan Gilbert" , peterx@redhat.com Add some explicit comment for both Readline and cpu_set/cpu_get helpers that they do not need the mon_lock protection. Signed-off-by: Peter Xu --- monitor.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/monitor.c b/monitor.c index d6c3c08932..ae5bca9d7c 100644 --- a/monitor.c +++ b/monitor.c @@ -207,7 +207,7 @@ struct Monitor { int suspend_cnt; /* Needs to be accessed atomically */ bool skip_flush; bool use_io_thr; - ReadLineState *rs; + ReadLineState *rs; /* Only used in parser, so no lock needed. */ MonitorQMP qmp; gchar *mon_cpu_path; BlockCompletionFunc *password_completion_cb; @@ -1313,7 +1313,7 @@ void qmp_qmp_capabilities(bool has_enable, QMPCapabilityList *enable, cur_mon->qmp.commands = &qmp_commands; } -/* set the current CPU defined by the user */ +/* set the current CPU defined by the user. BQL needed. */ int monitor_set_cpu(int cpu_index) { CPUState *cpu; @@ -1327,6 +1327,7 @@ int monitor_set_cpu(int cpu_index) return 0; } +/* BQL neeeded. */ static CPUState *mon_get_cpu_sync(bool synchronize) { CPUState *cpu; -- 2.17.0