From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Markus Armbruster <armbru@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Eric Blake <eblake@redhat.com>,
Michael Roth <mdroth@linux.vnet.ibm.com>
Subject: [Qemu-devel] [PATCH 08/13] tests: Add qdict_stringify_for_keyval() test
Date: Wed, 9 May 2018 18:55:25 +0200 [thread overview]
Message-ID: <20180509165530.29561-9-mreitz@redhat.com> (raw)
In-Reply-To: <20180509165530.29561-1-mreitz@redhat.com>
Signed-off-by: Max Reitz <mreitz@redhat.com>
---
tests/check-qdict.c | 54 +++++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 54 insertions(+)
diff --git a/tests/check-qdict.c b/tests/check-qdict.c
index 93e2112b6d..ef5d17f815 100644
--- a/tests/check-qdict.c
+++ b/tests/check-qdict.c
@@ -973,6 +973,57 @@ static void qdict_stress_test(void)
qobject_unref(qdict);
}
+static void qdict_stringify_for_keyval_test(void)
+{
+ QDict *dict = qdict_new();
+
+ /*
+ * Test stringification of:
+ *
+ * {
+ * "a": "null",
+ * "b": 42,
+ * "c": -23,
+ * "d": false,
+ * "e": null,
+ * "f": "",
+ * "g": 0.5,
+ * "h": 0xffffffffffffffff,
+ * "i": true,
+ * "j": 0
+ * }
+ *
+ * Note that null is not transformed into a string and remains a
+ * QNull.
+ */
+
+ qdict_put_str(dict, "a", "null");
+ qdict_put_int(dict, "b", 42);
+ qdict_put_int(dict, "c", -23);
+ qdict_put_bool(dict, "d", false);
+ qdict_put_null(dict, "e");
+ qdict_put_str(dict, "f", "");
+ qdict_put(dict, "g", qnum_from_double(0.5));
+ qdict_put(dict, "h", qnum_from_uint(0xffffffffffffffffull));
+ qdict_put_bool(dict, "i", true);
+ qdict_put_int(dict, "j", 0);
+
+ qdict_stringify_for_keyval(dict);
+
+ g_assert(!strcmp(qdict_get_str(dict, "a"), "null"));
+ g_assert(!strcmp(qdict_get_str(dict, "b"), "42"));
+ g_assert(!strcmp(qdict_get_str(dict, "c"), "-23"));
+ g_assert(!strcmp(qdict_get_str(dict, "d"), "off"));
+ g_assert(qobject_type(qdict_get(dict, "e")) == QTYPE_QNULL);
+ g_assert(!strcmp(qdict_get_str(dict, "f"), ""));
+ g_assert(!strcmp(qdict_get_str(dict, "g"), "0.5"));
+ g_assert(!strcmp(qdict_get_str(dict, "h"), "18446744073709551615"));
+ g_assert(!strcmp(qdict_get_str(dict, "i"), "on"));
+ g_assert(!strcmp(qdict_get_str(dict, "j"), "0"));
+
+ qobject_unref(dict);
+}
+
int main(int argc, char **argv)
{
g_test_init(&argc, &argv, NULL);
@@ -1010,6 +1061,9 @@ int main(int argc, char **argv)
g_test_add_func("/public/rename_keys", qdict_rename_keys_test);
+ g_test_add_func("/public/stringify_for_keyval",
+ qdict_stringify_for_keyval_test);
+
/* The Big one */
if (g_test_slow()) {
g_test_add_func("/stress/test", qdict_stress_test);
--
2.14.3
next prev parent reply other threads:[~2018-05-09 16:55 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 16:55 [Qemu-devel] [PATCH 00/13] block: Try to create well typed json:{} filenames Max Reitz
2018-05-09 16:55 ` [Qemu-devel] [PATCH 01/13] qapi: Add default-variant for flat unions Max Reitz
2018-05-10 13:12 ` Eric Blake
2018-05-10 13:18 ` Eric Blake
2018-05-11 17:59 ` Max Reitz
2018-05-11 18:13 ` Eric Blake
2018-05-11 17:38 ` Max Reitz
2018-05-09 16:55 ` [Qemu-devel] [PATCH 02/13] docs/qapi: Document optional discriminators Max Reitz
2018-05-10 13:14 ` Eric Blake
2018-05-09 16:55 ` [Qemu-devel] [PATCH 03/13] tests: Add QAPI optional discriminator tests Max Reitz
2018-05-10 14:08 ` Eric Blake
2018-05-11 18:06 ` Max Reitz
2018-05-09 16:55 ` [Qemu-devel] [PATCH 04/13] qapi: Formalize qcow2 encryption probing Max Reitz
2018-05-10 7:58 ` Daniel P. Berrangé
2018-05-10 14:22 ` Eric Blake
2018-05-11 17:32 ` Max Reitz
2018-05-09 16:55 ` [Qemu-devel] [PATCH 05/13] qapi: Formalize qcow " Max Reitz
2018-05-10 14:24 ` Eric Blake
2018-05-10 14:32 ` Daniel P. Berrangé
2018-05-11 18:07 ` Max Reitz
2018-05-09 16:55 ` [Qemu-devel] [PATCH 06/13] block: Add block-specific QDict header Max Reitz
2018-05-10 14:54 ` Eric Blake
2018-05-11 18:11 ` Max Reitz
2018-06-06 13:10 ` Markus Armbruster
2018-06-06 13:17 ` Markus Armbruster
2018-06-06 14:19 ` Markus Armbruster
2018-06-06 14:35 ` Markus Armbruster
2018-05-09 16:55 ` [Qemu-devel] [PATCH 07/13] qdict: Add qdict_stringify_for_keyval() Max Reitz
2018-05-11 18:39 ` Eric Blake
2018-05-11 21:42 ` Max Reitz
2018-05-09 16:55 ` Max Reitz [this message]
2018-05-10 16:02 ` [Qemu-devel] [PATCH 08/13] tests: Add qdict_stringify_for_keyval() test Eric Blake
2018-05-11 18:13 ` Max Reitz
2018-05-11 18:33 ` Eric Blake
2018-05-09 16:55 ` [Qemu-devel] [PATCH 09/13] qdict: Make qdict_flatten() shallow-clone-friendly Max Reitz
2018-05-11 18:44 ` Eric Blake
2018-05-09 16:55 ` [Qemu-devel] [PATCH 10/13] tests: Add QDict clone-flatten test Max Reitz
2018-05-11 18:46 ` Eric Blake
2018-05-11 21:41 ` Max Reitz
2018-05-09 16:55 ` [Qemu-devel] [PATCH 11/13] block: Try to create well typed json:{} filenames Max Reitz
2018-05-09 16:55 ` [Qemu-devel] [PATCH 12/13] iotests: Test internal option typing Max Reitz
2018-05-09 16:55 ` [Qemu-devel] [PATCH 13/13] iotests: qcow2's encrypt.format is now optional Max Reitz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180509165530.29561-9-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=armbru@redhat.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mdroth@linux.vnet.ibm.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).