qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
	John Snow <jsnow@redhat.com>, Eric Blake <eblake@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH v2 3/7] qemu-option: Pull out "Supported options" print
Date: Wed,  9 May 2018 23:00:19 +0200	[thread overview]
Message-ID: <20180509210023.20283-4-mreitz@redhat.com> (raw)
In-Reply-To: <20180509210023.20283-1-mreitz@redhat.com>

It really is up to the caller to decide what this list of options means.

Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: John Snow <jsnow@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
---
 qemu-img.c         | 1 +
 util/qemu-option.c | 1 -
 2 files changed, 1 insertion(+), 1 deletion(-)

diff --git a/qemu-img.c b/qemu-img.c
index 347cf2ed9f..c84d047872 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -261,6 +261,7 @@ static int print_block_option_help(const char *filename, const char *fmt)
         create_opts = qemu_opts_append(create_opts, proto_drv->create_opts);
     }
 
+    printf("Supported options:\n");
     qemu_opts_print_help(create_opts);
     qemu_opts_free(create_opts);
     return 0;
diff --git a/util/qemu-option.c b/util/qemu-option.c
index d0756fda58..95e6cf4e49 100644
--- a/util/qemu-option.c
+++ b/util/qemu-option.c
@@ -218,7 +218,6 @@ void qemu_opts_print_help(QemuOptsList *list)
 
     assert(list);
     desc = list->desc;
-    printf("Supported options:\n");
     while (desc && desc->name) {
         printf("%-16s %s\n", desc->name,
                desc->help ? desc->help : "No description available");
-- 
2.14.3

  parent reply	other threads:[~2018-05-09 21:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-09 21:00 [Qemu-devel] [PATCH v2 0/7] qemu-img: Improve option help for amend Max Reitz
2018-05-09 21:00 ` [Qemu-devel] [PATCH v2 1/7] qemu-img: Amendment support implies create_opts Max Reitz
2018-05-09 21:00 ` [Qemu-devel] [PATCH v2 2/7] block: Add Error parameter to bdrv_amend_options Max Reitz
2018-05-09 21:20   ` Eric Blake
2018-05-09 22:57   ` John Snow
2018-05-09 21:00 ` Max Reitz [this message]
2018-05-09 21:00 ` [Qemu-devel] [PATCH v2 4/7] qemu-img: Add print_amend_option_help() Max Reitz
2018-05-09 21:00 ` [Qemu-devel] [PATCH v2 5/7] qemu-img: Recognize no creation support in -o help Max Reitz
2018-05-09 21:00 ` [Qemu-devel] [PATCH v2 6/7] iotests: Test help option for unsupporting formats Max Reitz
2018-05-09 21:00 ` [Qemu-devel] [PATCH v2 7/7] iotests: Rework 113 Max Reitz
2018-06-01 11:06 ` [Qemu-devel] [PATCH v2 0/7] qemu-img: Improve option help for amend Max Reitz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180509210023.20283-4-mreitz@redhat.com \
    --to=mreitz@redhat.com \
    --cc=eblake@redhat.com \
    --cc=jsnow@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).