From: Stefan Hajnoczi <stefanha@redhat.com>
To: Peter Xu <peterx@redhat.com>
Cc: qemu-devel@nongnu.org, "Eric Blake" <eblake@redhat.com>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Markus Armbruster" <armbru@redhat.com>,
"Dr . David Alan Gilbert" <dgilbert@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v5 2/4] monitor: protect mon->fds with mon_lock
Date: Thu, 10 May 2018 11:11:58 +0100 [thread overview]
Message-ID: <20180510101158.GQ1296@stefanha-x1.localdomain> (raw)
In-Reply-To: <20180509041734.14135-3-peterx@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 395 bytes --]
On Wed, May 09, 2018 at 12:17:32PM +0800, Peter Xu wrote:
> mon->fds were protected by BQL. Now protect it by mon_lock so that it
> can even be used in monitor iothread.
Only monitor_get_fd() can safely be called from the monitor iothread
(oob).
The other functions call close(2), which may block, and therefore aren't
allowed in oob code.
Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 455 bytes --]
next prev parent reply other threads:[~2018-05-10 10:12 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 4:17 [Qemu-devel] [PATCH v5 0/4] monitor: let Monitor be thread safe Peter Xu
2018-05-09 4:17 ` [Qemu-devel] [PATCH v5 1/4] monitor: rename out_lock to mon_lock Peter Xu
2018-05-17 12:32 ` Markus Armbruster
2018-05-18 10:15 ` Peter Xu
2018-05-09 4:17 ` [Qemu-devel] [PATCH v5 2/4] monitor: protect mon->fds with mon_lock Peter Xu
2018-05-10 10:11 ` Stefan Hajnoczi [this message]
2018-05-17 12:47 ` Markus Armbruster
2018-05-09 4:17 ` [Qemu-devel] [PATCH v5 3/4] monitor: more comments on lock-free fleids/funcs Peter Xu
2018-05-10 10:12 ` Stefan Hajnoczi
2018-05-17 12:46 ` Markus Armbruster
2018-05-18 10:21 ` Peter Xu
2018-05-23 8:29 ` Markus Armbruster
2018-05-23 8:47 ` Peter Xu
2018-05-23 15:15 ` Markus Armbruster
2018-05-24 4:37 ` Peter Xu
2018-05-09 4:17 ` [Qemu-devel] [PATCH v5 4/4] monitor: add lock to protect mon_fdsets Peter Xu
2018-05-17 13:03 ` Markus Armbruster
2018-05-18 10:53 ` Peter Xu
2018-05-18 12:27 ` Markus Armbruster
2018-05-21 5:18 ` Peter Xu
2018-05-23 8:39 ` Markus Armbruster
2018-05-23 8:52 ` Peter Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510101158.GQ1296@stefanha-x1.localdomain \
--to=stefanha@redhat.com \
--cc=armbru@redhat.com \
--cc=dgilbert@redhat.com \
--cc=eblake@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).