From: Igor Mammedov <imammedo@redhat.com>
To: Ross Zwisler <ross.zwisler@linux.intel.com>
Cc: Haozhong Zhang <haozhong.zhang@intel.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Eduardo Habkost <ehabkost@redhat.com>,
qemu-devel@nongnu.org, linux-nvdimm <linux-nvdimm@lists.01.org>
Subject: Re: [Qemu-devel] [PATCH 1/3] nvdimm: fix typo in label-size definition
Date: Thu, 10 May 2018 15:06:51 +0200 [thread overview]
Message-ID: <20180510150651.2abd4a50@redhat.com> (raw)
In-Reply-To: <20180427215314.23168-1-ross.zwisler@linux.intel.com>
On Fri, 27 Apr 2018 15:53:12 -0600
Ross Zwisler <ross.zwisler@linux.intel.com> wrote:
> Signed-off-by: Ross Zwisler <ross.zwisler@linux.intel.com>
> Fixes: commit da6789c27c2e ("nvdimm: add a macro for property "label-size"")
> Cc: Haozhong Zhang <haozhong.zhang@intel.com>
> Cc: Michael S. Tsirkin <mst@redhat.com>
> Cc: Stefan Hajnoczi <stefanha@redhat.com>
Reviewed-by: Igor Mammedov <imammedo@redhat.com>
> ---
> hw/mem/nvdimm.c | 2 +-
> include/hw/mem/nvdimm.h | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/mem/nvdimm.c b/hw/mem/nvdimm.c
> index acb656b672..4087aca25e 100644
> --- a/hw/mem/nvdimm.c
> +++ b/hw/mem/nvdimm.c
> @@ -89,7 +89,7 @@ static void nvdimm_set_unarmed(Object *obj, bool value, Error **errp)
>
> static void nvdimm_init(Object *obj)
> {
> - object_property_add(obj, NVDIMM_LABLE_SIZE_PROP, "int",
> + object_property_add(obj, NVDIMM_LABEL_SIZE_PROP, "int",
> nvdimm_get_label_size, nvdimm_set_label_size, NULL,
> NULL, NULL);
> object_property_add_bool(obj, NVDIMM_UNARMED_PROP,
> diff --git a/include/hw/mem/nvdimm.h b/include/hw/mem/nvdimm.h
> index 7fd87c4e1c..74c60332e1 100644
> --- a/include/hw/mem/nvdimm.h
> +++ b/include/hw/mem/nvdimm.h
> @@ -48,7 +48,7 @@
> #define NVDIMM_GET_CLASS(obj) OBJECT_GET_CLASS(NVDIMMClass, (obj), \
> TYPE_NVDIMM)
>
> -#define NVDIMM_LABLE_SIZE_PROP "label-size"
> +#define NVDIMM_LABEL_SIZE_PROP "label-size"
> #define NVDIMM_UNARMED_PROP "unarmed"
>
> struct NVDIMMDevice {
prev parent reply other threads:[~2018-05-10 13:06 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-27 21:53 [Qemu-devel] [PATCH 1/3] nvdimm: fix typo in label-size definition Ross Zwisler
2018-04-27 21:53 ` [Qemu-devel] [PATCH 2/3] nvdimm, acpi: add NFIT platform capabilities Ross Zwisler
2018-04-30 11:39 ` Stefan Hajnoczi
2018-05-10 13:39 ` Igor Mammedov
2018-04-27 21:53 ` [Qemu-devel] [PATCH 3/3] nvdimm: platform capabilities command line option Ross Zwisler
2018-04-30 11:39 ` Stefan Hajnoczi
2018-05-10 13:28 ` Igor Mammedov
2018-05-15 23:03 ` Ross Zwisler
2018-05-16 7:22 ` Igor Mammedov
2018-04-30 11:38 ` [Qemu-devel] [PATCH 1/3] nvdimm: fix typo in label-size definition Stefan Hajnoczi
2018-05-03 22:20 ` Ross Zwisler
2018-05-04 8:44 ` Stefan Hajnoczi
2018-05-10 13:06 ` Igor Mammedov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180510150651.2abd4a50@redhat.com \
--to=imammedo@redhat.com \
--cc=ehabkost@redhat.com \
--cc=haozhong.zhang@intel.com \
--cc=linux-nvdimm@lists.01.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=ross.zwisler@linux.intel.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).