From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40670) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fGr2z-0006QD-T9 for qemu-devel@nongnu.org; Thu, 10 May 2018 15:16:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fGr2v-0003uL-S6 for qemu-devel@nongnu.org; Thu, 10 May 2018 15:16:13 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:54730 helo=mx1.redhat.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1fGr2v-0003mc-MM for qemu-devel@nongnu.org; Thu, 10 May 2018 15:16:09 -0400 Date: Thu, 10 May 2018 20:15:57 +0100 From: "Dr. David Alan Gilbert" Message-ID: <20180510191556.GB2679@work-vm> References: <20180413075200.15217-1-clg@kaod.org> <20180419165800.GA2731@work-vm> <20180509110833.GD2527@work-vm> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] [PATCH v2] migration: discard non-migratable RAMBlocks List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: =?iso-8859-1?Q?C=E9dric?= Le Goater , QEMU Developers , Juan Quintela , David Gibson , Alex Williamson , Yulei Zhang , "Tian, Kevin" , joonas.lahtinen@linux.intel.com, zhenyuw@linux.intel.com, Kirti Wankhede , zhi.a.wang@intel.com, Paolo Bonzini , Paul Burton , Aurelien Jarno , Yongbok Kim * Peter Maydell (peter.maydell@linaro.org) wrote: > On 9 May 2018 at 12:08, Dr. David Alan Gilbert wr= ote: > > This thread seems to have stalled; we've got the list of potential > > migration breaks that Peter found and only some minor comments on the > > actual patch. > > > > I'd like to get it going again sicne as well as C=E9dric, and Peter's > > cases, there's Lai Jiangshan and now Eric Wheeler was asking for > > something similar. > > > > Anyone understand the way forward? Do we have to go and fix the > > odd board failures first? >=20 > aspeed and highbank I already changed in master. That leaves >=20 > hw/mips/boston.c: memory_region_init_rom_nomigrate(flash, NULL, > hw/mips/mips_malta.c: memory_region_init_ram_nomigrate(bios_copy, > NULL, "bios.1fc", BIOS_SIZE, > hw/net/dp8393x.c: memory_region_init_ram_nomigrate(&s->prom, OBJECT(= dev), > [device only used on mips jazz board] > hw/pci-host/xilinx-pcie.c: memory_region_init_ram_nomigrate(&s->io, > OBJECT(s), "io", 16, NULL); > [device only used on mips boston board] >=20 > which affect mips boston, malta and jazz boards. >=20 > I don't think we need to fix those first, but: >=20 > * we should note in the commit message for this patch that > it is a de-facto migration break for those boards > * we should fix those devices/boards in this release cycle, > since we've broken migration compat anyway > * we should check with the MIPS maintainers that they're ok > with a cross-version migration compat break for those boards > (I've cc'd them) OK, in that case, as long as they're OK, then I think we should go for it. C=E9dric: Were you going to post a version that didn't do it in set_idstr? Dave > thanks > -- PMM -- Dr. David Alan Gilbert / dgilbert@redhat.com / Manchester, UK