From: Petr Tesarik <ptesarik@suse.com>
To: qemu-devel@nongnu.org
Cc: Petr Tesarik <ptesarik@suse.com>,
qemu-stable@nongnu.org, Aurelien Jarno <aurelien@aurel32.net>,
Peter Maydell <peter.maydell@linaro.org>
Subject: [Qemu-devel] [PATCH 1/1] Fix conversion from uint64 to float128
Date: Fri, 11 May 2018 09:10:52 +0200 [thread overview]
Message-ID: <20180511071052.1443-1-ptesarik@suse.com> (raw)
The significand is passed to normalizeRoundAndPackFloat128() as high
first, low second. The current code passes the integer first, so the
result is incorrectly shifted left by 64 bits.
This bug affects the emulation of s390x instruction CXLGBR (convert
from logical 64-bit binary-integer operand to extended BFP result).
Cc: qemu-stable@nongnu.org
Signed-off-by: Petr Tesarik <ptesarik@suse.com>
---
fpu/softfloat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fpu/softfloat.c b/fpu/softfloat.c
index 70e0c40a1c..386805475b 100644
--- a/fpu/softfloat.c
+++ b/fpu/softfloat.c
@@ -3139,7 +3139,7 @@ float128 uint64_to_float128(uint64_t a, float_status *status)
if (a == 0) {
return float128_zero;
}
- return normalizeRoundAndPackFloat128(0, 0x406E, a, 0, status);
+ return normalizeRoundAndPackFloat128(0, 0x406E, 0, a, status);
}
--
2.13.6
next reply other threads:[~2018-05-11 7:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-11 7:10 Petr Tesarik [this message]
2018-05-11 7:38 ` [Qemu-devel] [PATCH 1/1] Fix conversion from uint64 to float128 Petr Tesarik
2018-05-11 12:37 ` Peter Maydell
2018-05-12 0:52 ` Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511071052.1443-1-ptesarik@suse.com \
--to=ptesarik@suse.com \
--cc=aurelien@aurel32.net \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-stable@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).