From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51830) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fH2EU-0004F8-Nx for qemu-devel@nongnu.org; Fri, 11 May 2018 03:12:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fH2ES-0006t6-Iq for qemu-devel@nongnu.org; Fri, 11 May 2018 03:12:50 -0400 From: Petr Tesarik Date: Fri, 11 May 2018 09:10:52 +0200 Message-Id: <20180511071052.1443-1-ptesarik@suse.com> Subject: [Qemu-devel] [PATCH 1/1] Fix conversion from uint64 to float128 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Petr Tesarik , qemu-stable@nongnu.org, Aurelien Jarno , Peter Maydell The significand is passed to normalizeRoundAndPackFloat128() as high first, low second. The current code passes the integer first, so the result is incorrectly shifted left by 64 bits. This bug affects the emulation of s390x instruction CXLGBR (convert from logical 64-bit binary-integer operand to extended BFP result). Cc: qemu-stable@nongnu.org Signed-off-by: Petr Tesarik --- fpu/softfloat.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fpu/softfloat.c b/fpu/softfloat.c index 70e0c40a1c..386805475b 100644 --- a/fpu/softfloat.c +++ b/fpu/softfloat.c @@ -3139,7 +3139,7 @@ float128 uint64_to_float128(uint64_t a, float_status *status) if (a == 0) { return float128_zero; } - return normalizeRoundAndPackFloat128(0, 0x406E, a, 0, status); + return normalizeRoundAndPackFloat128(0, 0x406E, 0, a, status); } -- 2.13.6