From: Eduardo Habkost <ehabkost@redhat.com>
To: Liu Jingqi <jingqi.liu@intel.com>
Cc: pbonzini@redhat.com, rth@twiddle.net, mst@redhat.com,
imammedo@redhat.com, marcel.apfelbaum@gmail.com,
qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH v1 4/7] numa: Classify the numa nodes as memory initiators and memory targets
Date: Fri, 11 May 2018 11:33:00 -0300 [thread overview]
Message-ID: <20180511143300.GL25013@localhost.localdomain> (raw)
In-Reply-To: <1525854989-14165-1-git-send-email-jingqi.liu@intel.com>
On Wed, May 09, 2018 at 04:36:29PM +0800, Liu Jingqi wrote:
> An initiator proximity domain (memory initiator) is any device
> such as a CPU or a separate memory I/O device that can initiate
> a memory request. A target proximity domain (memory target)
> is a CPU-accessible physical address range.
>
[...]
> + if (node->cpus) {
> + initiator_pxm[num_initiator++] = nodenr;
> + }
[...]
> + target_pxm[num_target++] = nodenr;
I suggest NumaNode::is_initiator and NumaNode::is_target boolean
fields instead of a separate global table.
Or numa.c could simply provide
bool numa_node_is_initiator(int node) and
bool numa_node_is_target(int node)
helpers.
--
Eduardo
next prev parent reply other threads:[~2018-05-11 14:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-09 8:36 [Qemu-devel] [PATCH v1 4/7] numa: Classify the numa nodes as memory initiators and memory targets Liu Jingqi
2018-05-11 14:33 ` Eduardo Habkost [this message]
2018-05-14 5:22 ` Liu, Jingqi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180511143300.GL25013@localhost.localdomain \
--to=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jingqi.liu@intel.com \
--cc=marcel.apfelbaum@gmail.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).