qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, alex.bennee@linaro.org, qemu-stable@nongnu.org
Subject: [Qemu-devel] [PATCH v4 04/11] target/arm: Implement FCVT (scalar, fixed-point) for fp16
Date: Fri, 11 May 2018 17:32:10 -0700	[thread overview]
Message-ID: <20180512003217.9105-5-richard.henderson@linaro.org> (raw)
In-Reply-To: <20180512003217.9105-1-richard.henderson@linaro.org>

Cc: qemu-stable@nongnu.org
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
 target/arm/translate-a64.c | 17 +++++++++++++++--
 1 file changed, 15 insertions(+), 2 deletions(-)

diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c
index 93fb15d185..d0ed125442 100644
--- a/target/arm/translate-a64.c
+++ b/target/arm/translate-a64.c
@@ -5697,8 +5697,21 @@ static void disas_fp_fixed_conv(DisasContext *s, uint32_t insn)
     bool sf = extract32(insn, 31, 1);
     bool itof;
 
-    if (sbit || (type > 1)
-        || (!sf && scale < 32)) {
+    if (sbit || (!sf && scale < 32)) {
+        unallocated_encoding(s);
+        return;
+    }
+
+    switch (type) {
+    case 0: /* float32 */
+    case 1: /* float64 */
+        break;
+    case 3: /* float16 */
+        if (arm_dc_feature(s, ARM_FEATURE_V8_FP16)) {
+            break;
+        }
+        /* fallthru */
+    default:
         unallocated_encoding(s);
         return;
     }
-- 
2.17.0

  parent reply	other threads:[~2018-05-12  0:32 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-12  0:32 [Qemu-devel] [PATCH v4 00/11] target/arm: Fixups for ARM_FEATURE_V8_FP16 Richard Henderson
2018-05-12  0:32 ` [Qemu-devel] [PATCH v4 01/11] target/arm: Implement FMOV (general) for fp16 Richard Henderson
2018-05-15 10:37   ` Alex Bennée
2018-05-12  0:32 ` [Qemu-devel] [PATCH v4 02/11] target/arm: Early exit after unallocated_encoding in disas_fp_int_conv Richard Henderson
2018-05-15 10:37   ` Alex Bennée
2018-05-12  0:32 ` [Qemu-devel] [PATCH v4 03/11] target/arm: Implement FCVT (scalar, integer) for fp16 Richard Henderson
2018-05-13  7:21   ` Alex Bennée
2018-05-14 15:01     ` Richard Henderson
2018-05-14 15:52       ` Alex Bennée
2018-05-15 10:42         ` Alex Bennée
2018-05-12  0:32 ` Richard Henderson [this message]
2018-05-12  0:32 ` [Qemu-devel] [PATCH v4 05/11] target/arm: Introduce and use read_fp_hreg Richard Henderson
2018-05-15 10:39   ` Alex Bennée
2018-05-12  0:32 ` [Qemu-devel] [PATCH v4 06/11] target/arm: Implement FP data-processing (2 source) for fp16 Richard Henderson
2018-05-12  0:32 ` [Qemu-devel] [PATCH v4 07/11] target/arm: Implement FP data-processing (3 " Richard Henderson
2018-05-12  0:32 ` [Qemu-devel] [PATCH v4 08/11] target/arm: Implement FCMP " Richard Henderson
2018-05-12  0:32 ` [Qemu-devel] [PATCH v4 09/11] target/arm: Implement FCSEL " Richard Henderson
2018-05-12  0:32 ` [Qemu-devel] [PATCH v4 10/11] target/arm: Implement FMOV (immediate) " Richard Henderson
2018-05-12  0:32 ` [Qemu-devel] [PATCH v4 11/11] target/arm: Fix sqrt_f16 exception raising Richard Henderson
2018-05-13  7:22 ` [Qemu-devel] [PATCH v4 00/11] target/arm: Fixups for ARM_FEATURE_V8_FP16 Alex Bennée
2018-05-14 15:16 ` Peter Maydell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180512003217.9105-5-richard.henderson@linaro.org \
    --to=richard.henderson@linaro.org \
    --cc=alex.bennee@linaro.org \
    --cc=peter.maydell@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).