From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: "Michael S . Tsirkin" <mst@redhat.com>
Subject: [Qemu-devel] [PATCH 1/2] hw/virtio: Fix brace Werror with clang 6.0.0
Date: Fri, 11 May 2018 18:48:00 -0700 [thread overview]
Message-ID: <20180512014801.17566-1-richard.henderson@linaro.org> (raw)
The warning is
hw/virtio/vhost-user.c:1319:26: error: suggest braces
around initialization of subobject [-Werror,-Wmissing-braces]
VhostUserMsg msg = { 0 };
^
{}
While the original code is correct, and technically exactly correct
as per ISO C89, both GCC and Clang support plain empty set of braces
as an extension.
Cc: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
hw/virtio/vhost-user.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/virtio/vhost-user.c b/hw/virtio/vhost-user.c
index 38da8692bb..b455fca394 100644
--- a/hw/virtio/vhost-user.c
+++ b/hw/virtio/vhost-user.c
@@ -1316,7 +1316,7 @@ static bool vhost_user_requires_shm_log(struct vhost_dev *dev)
static int vhost_user_migration_done(struct vhost_dev *dev, char* mac_addr)
{
- VhostUserMsg msg = { 0 };
+ VhostUserMsg msg = { };
assert(dev->vhost_ops->backend_type == VHOST_BACKEND_TYPE_USER);
--
2.17.0
next reply other threads:[~2018-05-12 1:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 1:48 Richard Henderson [this message]
2018-05-12 1:48 ` [Qemu-devel] [PATCH 2/2] target/s390x: Fix brace Werror with clang 6.0.0 Richard Henderson
2018-05-14 15:44 ` Philippe Mathieu-Daudé
2018-05-14 15:44 ` [Qemu-devel] [PATCH 1/2] hw/virtio: " Philippe Mathieu-Daudé
2018-05-15 15:03 ` Eric Blake
-- strict thread matches above, loose matches on Subject: below --
2018-05-12 4:59 [Qemu-devel] [PATCH 0/9] target/m68k: Convert to TranslatorOps Richard Henderson
2018-05-12 4:59 ` [Qemu-devel] [PATCH 1/2] hw/virtio: Fix brace Werror with clang 6.0.0 Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180512014801.17566-1-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).