From: Richard Henderson <richard.henderson@linaro.org>
To: qemu-devel@nongnu.org
Cc: laurent@vivier.eu
Subject: [Qemu-devel] [PATCH 2/9] target/m68k: Replace DISAS_TB_JUMP with DISAS_NORETURN
Date: Fri, 11 May 2018 21:59:42 -0700 [thread overview]
Message-ID: <20180512045950.12386-4-richard.henderson@linaro.org> (raw)
In-Reply-To: <20180512045950.12386-1-richard.henderson@linaro.org>
We have exited the TB after using goto_tb; there is no
distinction from DISAS_NORETURN.
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>
---
target/m68k/translate.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/target/m68k/translate.c b/target/m68k/translate.c
index 86404906e0..6ab24fac0b 100644
--- a/target/m68k/translate.c
+++ b/target/m68k/translate.c
@@ -199,7 +199,6 @@ static void do_writebacks(DisasContext *s)
/* is_jmp field values */
#define DISAS_JUMP DISAS_TARGET_0 /* only pc was modified dynamically */
#define DISAS_UPDATE DISAS_TARGET_1 /* cpu state was modified dynamically */
-#define DISAS_TB_JUMP DISAS_TARGET_2 /* only pc was modified statically */
#define DISAS_JUMP_NEXT DISAS_TARGET_3
#if defined(CONFIG_USER_ONLY)
@@ -1496,7 +1495,7 @@ static void gen_jmp_tb(DisasContext *s, int n, uint32_t dest)
gen_jmp_im(s, dest);
tcg_gen_exit_tb(0);
}
- s->is_jmp = DISAS_TB_JUMP;
+ s->is_jmp = DISAS_NORETURN;
}
DISAS_INSN(scc)
@@ -6148,7 +6147,6 @@ void gen_intermediate_code(CPUState *cs, TranslationBlock *tb)
/* indicate that the hash table must be used to find the next TB */
tcg_gen_exit_tb(0);
break;
- case DISAS_TB_JUMP:
case DISAS_NORETURN:
/* nothing more to generate */
break;
--
2.17.0
next prev parent reply other threads:[~2018-05-12 5:00 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-12 4:59 [Qemu-devel] [PATCH 0/9] target/m68k: Convert to TranslatorOps Richard Henderson
2018-05-12 4:59 ` [Qemu-devel] [PATCH 1/2] hw/virtio: Fix brace Werror with clang 6.0.0 Richard Henderson
2018-05-12 4:59 ` [Qemu-devel] [PATCH 1/9] target/m68k: Use DISAS_NORETURN for exceptions Richard Henderson
2018-05-12 4:59 ` Richard Henderson [this message]
2018-05-12 4:59 ` [Qemu-devel] [PATCH 2/2] target/s390x: Fix brace Werror with clang 6.0.0 Richard Henderson
2018-05-12 7:56 ` David Hildenbrand
2018-05-14 10:16 ` Cornelia Huck
2018-05-12 4:59 ` [Qemu-devel] [PATCH 3/9] target/m68k: Remove DISAS_JUMP_NEXT as unused Richard Henderson
2018-05-12 4:59 ` [Qemu-devel] [PATCH 4/9] target/m68k: Use lookup_and_goto_tb for DISAS_JUMP Richard Henderson
-- strict thread matches above, loose matches on Subject: below --
2018-05-12 5:02 [Qemu-devel] [PATCH v1.1 0/9] target/m68k: Convert to TranslatorOps Richard Henderson
2018-05-12 5:02 ` [Qemu-devel] [PATCH 2/9] target/m68k: Replace DISAS_TB_JUMP with DISAS_NORETURN Richard Henderson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180512045950.12386-4-richard.henderson@linaro.org \
--to=richard.henderson@linaro.org \
--cc=laurent@vivier.eu \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).