From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
Markus Armbruster <armbru@redhat.com>,
qemu-ppc@nongnu.org, Pankaj Gupta <pagupta@redhat.com>,
Alexander Graf <agraf@suse.de>, Cornelia Huck <cohuck@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: [Qemu-devel] [PATCH v3 02/18] memory-device: introduce separate config option
Date: Mon, 14 May 2018 12:00:07 +0200 [thread overview]
Message-ID: <20180514100023.12542-3-david@redhat.com> (raw)
In-Reply-To: <20180514100023.12542-1-david@redhat.com>
Some architectures might support memory devices, while they don't
support DIMM/NVDIMM. So let's
- Rename CONFIG_MEM_HOTPLUG to CONFIG_MEM_DEVICE
- Intriduce CONFIG_DIMM and use it similarly to CONFIG NVDIMM
CONFIG_DIMM and CONFIG_NVDIMM require CONFIG_MEM_DEVICE.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
default-configs/i386-softmmu.mak | 3 ++-
default-configs/ppc64-softmmu.mak | 3 ++-
default-configs/x86_64-softmmu.mak | 3 ++-
hw/Makefile.objs | 2 +-
hw/mem/Makefile.objs | 4 ++--
qapi/misc.json | 2 +-
6 files changed, 10 insertions(+), 7 deletions(-)
diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak
index 8c7d4a0fa0..4c1637338b 100644
--- a/default-configs/i386-softmmu.mak
+++ b/default-configs/i386-softmmu.mak
@@ -50,7 +50,8 @@ CONFIG_PCI_Q35=y
CONFIG_APIC=y
CONFIG_IOAPIC=y
CONFIG_PVPANIC=y
-CONFIG_MEM_HOTPLUG=y
+CONFIG_MEM_DEVICE=y
+CONFIG_DIMM=y
CONFIG_NVDIMM=y
CONFIG_ACPI_NVDIMM=y
CONFIG_PCIE_PORT=y
diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak
index b94af6c7c6..f550573782 100644
--- a/default-configs/ppc64-softmmu.mak
+++ b/default-configs/ppc64-softmmu.mak
@@ -16,4 +16,5 @@ CONFIG_VIRTIO_VGA=y
CONFIG_XICS=$(CONFIG_PSERIES)
CONFIG_XICS_SPAPR=$(CONFIG_PSERIES)
CONFIG_XICS_KVM=$(call land,$(CONFIG_PSERIES),$(CONFIG_KVM))
-CONFIG_MEM_HOTPLUG=y
+CONFIG_MEM_DEVICE=y
+CONFIG_DIMM=y
diff --git a/default-configs/x86_64-softmmu.mak b/default-configs/x86_64-softmmu.mak
index 0390b4303c..7785351414 100644
--- a/default-configs/x86_64-softmmu.mak
+++ b/default-configs/x86_64-softmmu.mak
@@ -50,7 +50,8 @@ CONFIG_PCI_Q35=y
CONFIG_APIC=y
CONFIG_IOAPIC=y
CONFIG_PVPANIC=y
-CONFIG_MEM_HOTPLUG=y
+CONFIG_MEM_DEVICE=y
+CONFIG_DIMM=y
CONFIG_NVDIMM=y
CONFIG_ACPI_NVDIMM=y
CONFIG_PCIE_PORT=y
diff --git a/hw/Makefile.objs b/hw/Makefile.objs
index 6a0ffe0afd..127a60eca4 100644
--- a/hw/Makefile.objs
+++ b/hw/Makefile.objs
@@ -33,7 +33,7 @@ devices-dirs-$(CONFIG_SOFTMMU) += vfio/
devices-dirs-$(CONFIG_SOFTMMU) += virtio/
devices-dirs-$(CONFIG_SOFTMMU) += watchdog/
devices-dirs-$(CONFIG_SOFTMMU) += xen/
-devices-dirs-$(CONFIG_MEM_HOTPLUG) += mem/
+devices-dirs-$(CONFIG_MEM_DEVICE) += mem/
devices-dirs-$(CONFIG_SOFTMMU) += smbios/
devices-dirs-y += core/
common-obj-y += $(devices-dirs-y)
diff --git a/hw/mem/Makefile.objs b/hw/mem/Makefile.objs
index 10be4df2a2..3e2f7c5ca2 100644
--- a/hw/mem/Makefile.objs
+++ b/hw/mem/Makefile.objs
@@ -1,3 +1,3 @@
-common-obj-$(CONFIG_MEM_HOTPLUG) += pc-dimm.o
-common-obj-$(CONFIG_MEM_HOTPLUG) += memory-device.o
+common-obj-$(CONFIG_DIMM) += pc-dimm.o
+common-obj-$(CONFIG_MEM_DEVICE) += memory-device.o
common-obj-$(CONFIG_NVDIMM) += nvdimm.o
diff --git a/qapi/misc.json b/qapi/misc.json
index f5988cc0b5..65eae0c8a0 100644
--- a/qapi/misc.json
+++ b/qapi/misc.json
@@ -2060,7 +2060,7 @@
#
# @plugged-memory: size of memory that can be hot-unplugged. This field
# is omitted if target doesn't support memory hotplug
-# (i.e. CONFIG_MEM_HOTPLUG not defined on build time).
+# (i.e. CONFIG_MEM_DEVICE not defined on build time).
#
# Since: 2.11.0
##
--
2.14.3
next prev parent reply other threads:[~2018-05-14 10:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 10:00 [Qemu-devel] [PATCH v3 00/18] MemoryDevice: use multi stage hotplug handlers David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 01/18] memory-device: drop assert related to align and start of address space David Hildenbrand
2018-05-14 10:00 ` David Hildenbrand [this message]
2018-05-15 0:20 ` [Qemu-devel] [Qemu-ppc] [PATCH v3 02/18] memory-device: introduce separate config option Murilo Opsfelder Araujo
2018-05-15 15:21 ` Eric Blake
2018-05-16 9:31 ` David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 03/18] qdev: let machine hotplug handler to override bus hotplug handler David Hildenbrand
2018-05-15 0:00 ` [Qemu-devel] [Qemu-ppc] " Murilo Opsfelder Araujo
2018-05-15 8:07 ` David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 04/18] pc: prepare for multi stage hotplug handlers David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 05/18] pc: route all memory devices through the machine hotplug handler David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 06/18] spapr: prepare for multi stage hotplug handlers David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 07/18] spapr: route all memory devices through the machine hotplug handler David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 08/18] spapr: handle pc-dimm unplug via hotplug handler chain David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 09/18] spapr: handle cpu core " David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 10/18] memory-device: new functions to handle plug/unplug David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 11/18] pc-dimm: implement new memory device functions David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 12/18] memory-device: factor out pre-plug into hotplug handler David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 13/18] memory-device: factor out unplug " David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 14/18] memory-device: factor out plug " David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 15/18] s390x/sclp: make sure ram_size and maxram_size stay in sync David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 16/18] s390x: prepare for multi stage hotplug handlers David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 17/18] s390x: initialize memory region for memory devices David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 18/18] s390x: support " David Hildenbrand
2018-05-14 10:38 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514100023.12542-3-david@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).