From: David Hildenbrand <david@redhat.com>
To: qemu-devel@nongnu.org
Cc: qemu-s390x@nongnu.org, "Michael S . Tsirkin" <mst@redhat.com>,
Igor Mammedov <imammedo@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>,
David Gibson <david@gibson.dropbear.id.au>,
Markus Armbruster <armbru@redhat.com>,
qemu-ppc@nongnu.org, Pankaj Gupta <pagupta@redhat.com>,
Alexander Graf <agraf@suse.de>, Cornelia Huck <cohuck@redhat.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Luiz Capitulino <lcapitulino@redhat.com>,
David Hildenbrand <david@redhat.com>
Subject: [Qemu-devel] [PATCH v3 05/18] pc: route all memory devices through the machine hotplug handler
Date: Mon, 14 May 2018 12:00:10 +0200 [thread overview]
Message-ID: <20180514100023.12542-6-david@redhat.com> (raw)
In-Reply-To: <20180514100023.12542-1-david@redhat.com>
Necessary to hotplug them cleanly later. We could drop the PC_DIMM
check, as PC_DIMM are just memory devices, but this approach is cleaner.
Signed-off-by: David Hildenbrand <david@redhat.com>
---
hw/i386/pc.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index 510076e156..8bc41ef24b 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -74,6 +74,7 @@
#include "hw/nmi.h"
#include "hw/i386/intel_iommu.h"
#include "hw/net/ne2000-isa.h"
+#include "hw/mem/memory-device.h"
/* debug PC/ISA interrupts */
//#define DEBUG_IRQ
@@ -2075,6 +2076,7 @@ static HotplugHandler *pc_get_hotpug_handler(MachineState *machine,
DeviceState *dev)
{
if (object_dynamic_cast(OBJECT(dev), TYPE_PC_DIMM) ||
+ object_dynamic_cast(OBJECT(dev), TYPE_MEMORY_DEVICE) ||
object_dynamic_cast(OBJECT(dev), TYPE_CPU)) {
return HOTPLUG_HANDLER(machine);
}
--
2.14.3
next prev parent reply other threads:[~2018-05-14 10:00 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-14 10:00 [Qemu-devel] [PATCH v3 00/18] MemoryDevice: use multi stage hotplug handlers David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 01/18] memory-device: drop assert related to align and start of address space David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 02/18] memory-device: introduce separate config option David Hildenbrand
2018-05-15 0:20 ` [Qemu-devel] [Qemu-ppc] " Murilo Opsfelder Araujo
2018-05-15 15:21 ` Eric Blake
2018-05-16 9:31 ` David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 03/18] qdev: let machine hotplug handler to override bus hotplug handler David Hildenbrand
2018-05-15 0:00 ` [Qemu-devel] [Qemu-ppc] " Murilo Opsfelder Araujo
2018-05-15 8:07 ` David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 04/18] pc: prepare for multi stage hotplug handlers David Hildenbrand
2018-05-14 10:00 ` David Hildenbrand [this message]
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 06/18] spapr: " David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 07/18] spapr: route all memory devices through the machine hotplug handler David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 08/18] spapr: handle pc-dimm unplug via hotplug handler chain David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 09/18] spapr: handle cpu core " David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 10/18] memory-device: new functions to handle plug/unplug David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 11/18] pc-dimm: implement new memory device functions David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 12/18] memory-device: factor out pre-plug into hotplug handler David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 13/18] memory-device: factor out unplug " David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 14/18] memory-device: factor out plug " David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 15/18] s390x/sclp: make sure ram_size and maxram_size stay in sync David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 16/18] s390x: prepare for multi stage hotplug handlers David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 17/18] s390x: initialize memory region for memory devices David Hildenbrand
2018-05-14 10:00 ` [Qemu-devel] [PATCH v3 18/18] s390x: support " David Hildenbrand
2018-05-14 10:38 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180514100023.12542-6-david@redhat.com \
--to=david@redhat.com \
--cc=agraf@suse.de \
--cc=armbru@redhat.com \
--cc=borntraeger@de.ibm.com \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pagupta@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).