qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Jeff Cody <jcody@redhat.com>
To: Stefan Hajnoczi <stefanha@redhat.com>
Cc: qemu-devel@nongnu.org, qemu-block@nongnu.org,
	Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Subject: Re: [Qemu-devel] [PATCH v2 0/2] qemu-iotests: post-QEMU 2.12 fixes for 185
Date: Mon, 14 May 2018 07:40:10 -0400	[thread overview]
Message-ID: <20180514114010.GA868@localhost.localdomain> (raw)
In-Reply-To: <20180508135436.30140-1-stefanha@redhat.com>

On Tue, May 08, 2018 at 02:54:34PM +0100, Stefan Hajnoczi wrote:
> v2:
>  * Rebase onto Jeff's block tree to get mirror ratelimit fix [Jeff, Vladimir]
>  * Update comments in 185 since drain no longer causes a spurious iteration
> 
> The 185 qemu-iotests test case was in a bad state for the QEMU 2.12 release.
> We fudged the expected test output to make it pass, except for
> non-deterministic behavior.
> 
> These patches get us back to pre-QEMU 2.12.  Notably the offsets reported in
> block job events now correspond to smaller buffer sizes because the job doesn't
> iterate during drain.
> 
> It's worth mentioning that the test case is still non-deterministic.  For more
> on that, see the first patch.
> 
> Stefan Hajnoczi (2):
>   qemu-iotests: reduce chance of races in 185
>   blockjob: do not cancel timer in resume
> 
>  blockjob.c                 | 22 +++++++++++++++-------
>  tests/qemu-iotests/185     | 17 +++++++++++++----
>  tests/qemu-iotests/185.out | 12 +++++-------
>  3 files changed, 33 insertions(+), 18 deletions(-)
> 
> -- 
> 2.14.3
> 

Thanks,

Applied to my block branch:

git://github.com/codyprime/qemu-kvm-jtc block

-Jeff

      parent reply	other threads:[~2018-05-14 11:40 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-08 13:54 [Qemu-devel] [PATCH v2 0/2] qemu-iotests: post-QEMU 2.12 fixes for 185 Stefan Hajnoczi
2018-05-08 13:54 ` [Qemu-devel] [PATCH v2 1/2] qemu-iotests: reduce chance of races in 185 Stefan Hajnoczi
2018-05-08 14:26   ` Eric Blake
2018-05-10 10:05     ` Stefan Hajnoczi
2018-05-10 13:24       ` Eric Blake
2018-05-10 14:01   ` Vladimir Sementsov-Ogievskiy
2018-05-08 13:54 ` [Qemu-devel] [PATCH v2 2/2] blockjob: do not cancel timer in resume Stefan Hajnoczi
2018-05-08 14:28   ` Eric Blake
2018-05-14  8:35   ` QingFeng Hao
2018-05-14 11:40 ` Jeff Cody [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180514114010.GA868@localhost.localdomain \
    --to=jcody@redhat.com \
    --cc=kwolf@redhat.com \
    --cc=mreitz@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).