* [Qemu-devel] [PATCH] sdl2: move opts assignment into loop
@ 2018-05-15 8:23 Gerd Hoffmann
2018-05-15 8:43 ` Philippe Mathieu-Daudé
0 siblings, 1 reply; 2+ messages in thread
From: Gerd Hoffmann @ 2018-05-15 8:23 UTC (permalink / raw)
To: qemu-devel; +Cc: Gerd Hoffmann
So the opts pointer is set for all sdl2_consoles.
Fixes: 844fd50dbbcfc9e401895274bf4fb8da8e8d3f64
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
ui/sdl2.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ui/sdl2.c b/ui/sdl2.c
index da037248c2..a0f9b16bc1 100644
--- a/ui/sdl2.c
+++ b/ui/sdl2.c
@@ -804,7 +804,6 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
return;
}
sdl2_console = g_new0(struct sdl2_console, sdl2_num_outputs);
- sdl2_console->opts = o;
for (i = 0; i < sdl2_num_outputs; i++) {
QemuConsole *con = qemu_console_lookup_by_index(i);
assert(con != NULL);
@@ -812,6 +811,7 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
sdl2_console[i].hidden = true;
}
sdl2_console[i].idx = i;
+ sdl2_console[i].opts = o;
#ifdef CONFIG_OPENGL
sdl2_console[i].opengl = display_opengl;
sdl2_console[i].dcl.ops = display_opengl ? &dcl_gl_ops : &dcl_2d_ops;
--
2.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] sdl2: move opts assignment into loop
2018-05-15 8:23 [Qemu-devel] [PATCH] sdl2: move opts assignment into loop Gerd Hoffmann
@ 2018-05-15 8:43 ` Philippe Mathieu-Daudé
0 siblings, 0 replies; 2+ messages in thread
From: Philippe Mathieu-Daudé @ 2018-05-15 8:43 UTC (permalink / raw)
To: Gerd Hoffmann, qemu-devel
On 05/15/2018 05:23 AM, Gerd Hoffmann wrote:
> So the opts pointer is set for all sdl2_consoles.
>
> Fixes: 844fd50dbbcfc9e401895274bf4fb8da8e8d3f64
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
> ---
> ui/sdl2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/ui/sdl2.c b/ui/sdl2.c
> index da037248c2..a0f9b16bc1 100644
> --- a/ui/sdl2.c
> +++ b/ui/sdl2.c
> @@ -804,7 +804,6 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
> return;
> }
> sdl2_console = g_new0(struct sdl2_console, sdl2_num_outputs);
> - sdl2_console->opts = o;
> for (i = 0; i < sdl2_num_outputs; i++) {
> QemuConsole *con = qemu_console_lookup_by_index(i);
> assert(con != NULL);
> @@ -812,6 +811,7 @@ static void sdl2_display_init(DisplayState *ds, DisplayOptions *o)
> sdl2_console[i].hidden = true;
> }
> sdl2_console[i].idx = i;
> + sdl2_console[i].opts = o;
> #ifdef CONFIG_OPENGL
> sdl2_console[i].opengl = display_opengl;
> sdl2_console[i].dcl.ops = display_opengl ? &dcl_gl_ops : &dcl_2d_ops;
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-05-15 8:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-05-15 8:23 [Qemu-devel] [PATCH] sdl2: move opts assignment into loop Gerd Hoffmann
2018-05-15 8:43 ` Philippe Mathieu-Daudé
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).