From: "Daniel P. Berrangé" <berrange@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: Peter Wu <peter@lekensteyn.nl>, qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH 2/2] gtk: disable the F10 menubar key
Date: Tue, 15 May 2018 09:39:12 +0100 [thread overview]
Message-ID: <20180515083912.GE24129@redhat.com> (raw)
In-Reply-To: <20180515083009.eo6bh6x2flzhmogv@sirius.home.kraxel.org>
On Tue, May 15, 2018 at 10:30:09AM +0200, Gerd Hoffmann wrote:
> On Fri, May 11, 2018 at 01:07:39AM +0200, Peter Wu wrote:
> > The F10 key is used in various applications, disable it unconditionally
> > (do not limit it to grab mode). Note that this property is deprecated
> > and might be removed in the future (GTK+ commit b082fb598d).
>
> Any replacement provided by gtk?
It doesn't look like it
> I don't feel like adding new code depending on already deprecated
> features ...
>
> Also note that there is the "grab-on-hover" option in the view menu,
> which will make qemu grab the keyboard if the mouse pointer is inside
> the qemu window. Which is pretty convinient for hotkeys, they go to the
> guest if you work in the qemu window and to the host otherwise.
IMHO the right thing todo long term is to kill the menu bar from the
GTK UI entirely, and replace with the GTK HeaderBar. This allows the
menu items to be provided via popups directly from the title bar of
the windows, which is more vertically space efficient. This would
probably have to wait for us to ditch GTK2, so I think this fix is
reasonable until that time.
Regards,
Daniel
--
|: https://berrange.com -o- https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o- https://fstop138.berrange.com :|
|: https://entangle-photo.org -o- https://www.instagram.com/dberrange :|
next prev parent reply other threads:[~2018-05-15 8:39 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-10 23:07 [Qemu-devel] [PATCH 1/2] gtk: make it possible to hide the menu bar Peter Wu
2018-05-10 23:07 ` [Qemu-devel] [PATCH 2/2] gtk: disable the F10 menubar key Peter Wu
2018-05-15 8:30 ` Gerd Hoffmann
2018-05-15 8:39 ` Daniel P. Berrangé [this message]
2018-05-15 8:46 ` Gerd Hoffmann
2018-05-15 8:55 ` Peter Wu
2018-05-15 8:32 ` [Qemu-devel] [PATCH 1/2] gtk: make it possible to hide the menu bar Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180515083912.GE24129@redhat.com \
--to=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=peter@lekensteyn.nl \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).